Skip to content

Conversation

@antlypls
Copy link
Contributor

JIRA: https://issues.apache.org/jira/browse/SPARK-12744

This PR makes parsing JSON integers to timestamps consistent with casting behavior.

@antlypls
Copy link
Contributor Author

cc @yhuai

@yhuai
Copy link
Contributor

yhuai commented Jan 11, 2016

ok to test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we use

withTempTable("jsonTable") {
  ... the test ...
}

withTempTable can automatically drop the temp table.

@yhuai
Copy link
Contributor

yhuai commented Jan 11, 2016

@antlypls Thank you for the PR! Overall it looks good. Just left two comments about the test.

@SparkQA
Copy link

SparkQA commented Jan 11, 2016

Test build #49086 has finished for PR 10687 at commit 2c79bef.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@antlypls antlypls force-pushed the fix-json-timestamp-parsing branch from 2c79bef to 600f73f Compare January 11, 2016 08:09
@antlypls
Copy link
Contributor Author

@yhuai I've updated test according to your comments, not sure why build failed.

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 11, 2016

Test build #49108 has finished for PR 10687 at commit 600f73f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 11, 2016

Test build #49118 has finished for PR 10687 at commit 600f73f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Jan 11, 2016

LGTM. Merging to master.

@asfgit asfgit closed this in 9559ac5 Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants