-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-12692][BUILD][CORE] Scala style: Fix the style violation (Space before ",") #10719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we also need to modify MimaExclude.scala.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we reset this change and just turn the rule off here-- otherwise the huge mima exclusion is pretty annoying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's reasonable. I'll do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should we reset the change in flume/sink/Logging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is less big of a deal there since it is already done and it is small. But feel free to do whatever you deem fit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O.K, it's less big deal. I'll only reset for this change.
|
Test build #49217 has finished for PR 10719 at commit
|
|
Test build #49221 has finished for PR 10719 at commit
|
5d4b1a9 to
e953d13
Compare
|
Test build #49234 has finished for PR 10719 at commit
|
|
The additional mima exclusions are few so I'll add them. |
|
Test build #49230 has finished for PR 10719 at commit
|
|
Test build #49236 has finished for PR 10719 at commit
|
|
I responded here: #10685 (comment) Pasting the message here too: In many cases for type bounds, ti is good to have a space before the colon so it is more clear. For comma, we should always have it (at least I haven't seen a case in which we don't want it yet). |
9079c27 to
284da4b
Compare
|
Test build #49280 has finished for PR 10719 at commit
|
|
I've merged this. |
Fix the style violation (space before , and :).
This PR is a followup for #10643