Skip to content

[SPARK-12749][SQL] add json option to parse floating-point types as DecimalType #10936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
blbradley wants to merge 3 commits into from
Closed

[SPARK-12749][SQL] add json option to parse floating-point types as DecimalType #10936

blbradley wants to merge 3 commits into from

Conversation

@blbradley
Copy link
Contributor

@blbradley blbradley commented Jan 27, 2016

I tried to add this via USE_BIG_DECIMAL_FOR_FLOATS option from Jackson with no success.

Added test for non-complex types. Should I add a test for complex types?

rxin
rxin reviewed Jan 27, 2016
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/InferSchema.scala Outdated
Copy link
Contributor

@rxin rxin Jan 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the todo above

@SparkQA
Copy link

SparkQA commented Jan 27, 2016

Test build #2467 has finished for PR 10936 at commit c344359.

  • This patch fails Scala style tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@blbradley
Copy link
Contributor Author

blbradley commented Jan 28, 2016

I had an unused import. My apologies!

@blbradley
Copy link
Contributor Author

blbradley commented Jan 28, 2016

@rxin can you start the test again?

@SparkQA
Copy link

SparkQA commented Jan 28, 2016

Test build #2469 has finished for PR 10936 at commit f141097.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@blbradley
Copy link
Contributor Author

blbradley commented Jan 28, 2016

Sweet. Anything else?

@rxin
Copy link
Contributor

rxin commented Jan 28, 2016

Thanks - I've merged this.

@asfgit asfgit closed this in 3a40c0e Jan 28, 2016
@blbradley blbradley deleted the spark-12749 branch January 29, 2016 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blbradley @SparkQA @rxin