Skip to content

Conversation

@zhuoliu
Copy link

@zhuoliu zhuoliu commented Feb 25, 2016

What changes were proposed in this pull request?

Now by default, it shows as ascending order of appId. We might prefer to display as descending order by default, which will show the latest application at the top.

How was this patch tested?

Manual tested. See screenshot below:

desc-sort

@srowen
Copy link
Member

srowen commented Feb 25, 2016

Jenkins, test this please

@srowen
Copy link
Member

srowen commented Feb 25, 2016

Descending by app ID != most recent first, right? I could see an argument for the latter but I'm not sure that's what this does. In your example, you even see it shows "local" apps first.

@SparkQA
Copy link

SparkQA commented Feb 25, 2016

Test build #51965 has finished for PR 11357 at commit dfe86bc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tgravescs
Copy link
Contributor

descending puts all the applications with application_ in the order with most recent on top. Since its still sorting alphabetically it puts the local- before the application_. I think this is better then ascending where the least recent is on top.

The only other thing we could do is change it to sort numeric and special handle local- vs application_.
Or sort by date by default.

In our case I wouldn't normally expect to see both the local- and application_ in the same history server.

@tgravescs
Copy link
Contributor

+1 on this. @srowen let me know if you have concerns still or if we didn't describe well enough.

@srowen
Copy link
Member

srowen commented Feb 25, 2016

Could we just sort by start time? that sounds like the goal.

@tgravescs
Copy link
Contributor

So we could. I was hoping for it to be similar to the YARN RM ui where it sorted by app id. To me its also most intuitive to have first column sorted.

The time isn't necessarily the same as appid order because the application first requests id before ever submitting it. So sorting by time could end up with app ids out of order if one takes longer to actually submit and start.

@zhuoliu
Copy link
Author

zhuoliu commented Feb 26, 2016

This basically provides a default view of sorting when the page is loaded. User can easily sort by start time or other columns by clicking the column name.

@tgravescs
Copy link
Contributor

since this is just changing the default order to descending I'm going to check this in, if we want to change which column its sorted by lets file a separate jira.

@asfgit asfgit closed this in 2f91f5a Feb 29, 2016
@srowen
Copy link
Member

srowen commented Feb 29, 2016

I don't mind the change if @zhuoliu doesn't since the original idea was to sort by start time. Meh, maybe the JIRA title could be updated but not a big deal.

@zjffdu
Copy link
Contributor

zjffdu commented Feb 29, 2016

agree with sorting on start time. different mode has different format of app_id. sorting by start time is more reasonable.

@tgravescs
Copy link
Contributor

fyi https://issues.apache.org/jira/browse/SPARK-13775 to sort by completed time.

roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
## What changes were proposed in this pull request?

Now by default, it shows as ascending order of appId. We might prefer to display as descending order by default, which will show the latest application at the top.

## How was this patch tested?

Manual tested. See screenshot below:

![desc-sort](https://cloud.githubusercontent.com/assets/11683054/13307473/102f4cf8-db31-11e5-8dd5-391edbf32f0d.png)

Author: zhuol <zhuol@yahoo-inc.com>

Closes apache#11357 from zhuoliu/13481.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants