-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-13481] Desc order of appID by default for history server page. #11357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Jenkins, test this please |
|
Descending by app ID != most recent first, right? I could see an argument for the latter but I'm not sure that's what this does. In your example, you even see it shows "local" apps first. |
|
Test build #51965 has finished for PR 11357 at commit
|
|
descending puts all the applications with application_ in the order with most recent on top. Since its still sorting alphabetically it puts the local- before the application_. I think this is better then ascending where the least recent is on top. The only other thing we could do is change it to sort numeric and special handle local- vs application_. In our case I wouldn't normally expect to see both the local- and application_ in the same history server. |
|
+1 on this. @srowen let me know if you have concerns still or if we didn't describe well enough. |
|
Could we just sort by start time? that sounds like the goal. |
|
So we could. I was hoping for it to be similar to the YARN RM ui where it sorted by app id. To me its also most intuitive to have first column sorted. The time isn't necessarily the same as appid order because the application first requests id before ever submitting it. So sorting by time could end up with app ids out of order if one takes longer to actually submit and start. |
|
This basically provides a default view of sorting when the page is loaded. User can easily sort by start time or other columns by clicking the column name. |
|
since this is just changing the default order to descending I'm going to check this in, if we want to change which column its sorted by lets file a separate jira. |
|
I don't mind the change if @zhuoliu doesn't since the original idea was to sort by start time. Meh, maybe the JIRA title could be updated but not a big deal. |
|
agree with sorting on start time. different mode has different format of app_id. sorting by start time is more reasonable. |
|
fyi https://issues.apache.org/jira/browse/SPARK-13775 to sort by completed time. |
## What changes were proposed in this pull request? Now by default, it shows as ascending order of appId. We might prefer to display as descending order by default, which will show the latest application at the top. ## How was this patch tested? Manual tested. See screenshot below:  Author: zhuol <zhuol@yahoo-inc.com> Closes apache#11357 from zhuoliu/13481.
What changes were proposed in this pull request?
Now by default, it shows as ascending order of appId. We might prefer to display as descending order by default, which will show the latest application at the top.
How was this patch tested?
Manual tested. See screenshot below: