[SPARK-13738][SQL] Cleanup Data Source resolution #11572
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmbrus
changed the title
|
Test build #52624 has finished for PR 11572 at commit
|
|
Test build #52625 has finished for PR 11572 at commit
|
|
Test build #52637 has finished for PR 11572 at commit
|
|
Test build #52639 has finished for PR 11572 at commit
|
|
Test build #52634 has finished for PR 11572 at commit
|
| * The main class responsible for representing a pluggable Data Source in Spark SQL. In addition to | ||
| * acting as the canonical set of parameters that can describe a Data Source, this class is used to | ||
| * resolve a description to a concrete implementation that can be used in a query plan | ||
| * (either batch or streaming) or to write out out data using an external library. |
Member
|
While taking a look, I also saw some nits in the previous PR, #11509. At
|
|
Test build #52674 has finished for PR 11572 at commit
|
Contributor
|
LGTM - merging in master. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
Follow-up to apache#11509, that simply refactors the interface that we use when resolving a pluggable `DataSource`. - Multiple functions share the same set of arguments so we make this a case class, called `DataSource`. Actual resolution is now done by calling a function on this class. - Instead of having multiple methods named `apply` (some of which do writing some of which do reading) we now explicitly have `resolveRelation()` and `write(mode, df)`. - Get rid of `Array[String]` since this is an internal API and was forcing us to awkwardly call `toArray` in a bunch of places. Author: Michael Armbrust <michael@databricks.com> Closes apache#11572 from marmbrus/dataSourceResolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11509, that simply refactors the interface that we use when resolving a pluggable
DataSource.DataSource. Actual resolution is now done by calling a function on this class.apply(some of which do writing some of which do reading) we now explicitly haveresolveRelation()andwrite(mode, df).Array[String]since this is an internal API and was forcing us to awkwardly calltoArrayin a bunch of places.