Skip to content

Conversation

@jaceklaskowski
Copy link
Contributor

What changes were proposed in this pull request?

Upgrade to 2.11.8 (from the current 2.11.7)

How was this patch tested?

A manual build

@srowen
Copy link
Member

srowen commented Mar 13, 2016

Jenkins test this please

@srowen
Copy link
Member

srowen commented Mar 13, 2016

This is OK for 2.x of course, and 1.6.x too I think. It's just a bug release, and the 2.11 build is the secondary one for 1.6 anyway, so slightly lower risk in any event.

@SparkQA
Copy link

SparkQA commented Mar 13, 2016

Test build #53027 has finished for PR 11681 at commit 5ae9816.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

Hey @jaceklaskowski, you should run ./dev/test-dependencies.sh --replace-manifest and commit the result in order to get the dependency tests to pass.

@jaceklaskowski
Copy link
Contributor Author

@srowen Mind triggering a test? Thanks!

@srowen
Copy link
Member

srowen commented Mar 15, 2016

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Mar 15, 2016

Test build #53206 has finished for PR 11681 at commit 3e3356c.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Mar 15, 2016

(Copying part of my email) This fails because we don't have the fork of genjavadoc compiled for Spark 2.11.8.

We can see the org.spark-project packages here:

http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.spark-project%22

I've forgotten who maintains the custom fork builds, and I don't know
the reasons we needed a fork of genjavadoc. Is it still relevant?

Heh, there's no plugin for 2.11.8 from the upstream project either anyway:
http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22com.typesafe.genjavadoc%22

This may be blocked for now

@srowen
Copy link
Member

srowen commented Mar 23, 2016

@mengxr is it possible to generate these plugins one more time for Scala 2.11.8 and 2.10.6? Maybe it's the last time we need to.
(Upstream now has plugins for 2.11.8/2.10.6)

@mengxr
Copy link
Contributor

mengxr commented Mar 23, 2016

I will do a cross build and @brkyvz will help publish the jars. cc: @jodersky

@brkyvz
Copy link
Contributor

brkyvz commented Mar 24, 2016

@mengxr @srowen @jaceklaskowski Jars are now published. They should be available in a couple of hours if not already.

@srowen
Copy link
Member

srowen commented Mar 25, 2016

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Mar 25, 2016

Test build #54174 has finished for PR 11681 at commit 3e3356c.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Mar 26, 2016

Thanks @brkyvz -- it doesn't look like it pushed yet but maybe there's a delay. I can check again in a few days. http://search.maven.org/#search%7Cga%7C1%7Corg.spark-project%20genjavadoc

@srowen
Copy link
Member

srowen commented Mar 31, 2016

@brkyvz @mengxr it looks like the artifacts haven't pushed. Is it possible to double-check what happened there?

@brkyvz
Copy link
Contributor

brkyvz commented Mar 31, 2016

@srowen I realized that I forgot to push the release button :( They've been available under staging repositories at:
https://oss.sonatype.org/content/repositories/orgspark-project-1118 and
https://oss.sonatype.org/content/repositories/orgspark-project-1119

very sorry for the delay

@srowen
Copy link
Member

srowen commented Mar 31, 2016

Ha yeah I've done that before in Sonatype.

@srowen
Copy link
Member

srowen commented Mar 31, 2016

Jenkins retest this please

@jodersky
Copy link
Member

FYI, I have two PRs pending to get the genjavadoc changes merged into upstream. I haven't had any feedback yet so if anyone wants to have a look please do lightbend/genjavadoc#70 lightbend/genjavadoc#71

@SparkQA
Copy link

SparkQA commented Apr 1, 2016

Test build #54679 has finished for PR 11681 at commit 3e3356c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Apr 1, 2016

Merged to master

@asfgit asfgit closed this in c16a396 Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants