[SPARK-13899][SQL] Produce InternalRow instead of external Row at CSV data source #11717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #53179 has finished for PR 11717 at commit
|
|
Test build #53180 has finished for PR 11717 at commit
|
Member
Author
|
This PR would allow to infer |
|
Test build #53189 has finished for PR 11717 at commit
|
| case dt: DecimalType => | ||
| val value = new BigDecimal(datum.replaceAll(",", "")) | ||
| Decimal(value, dt.precision, dt.scale) | ||
| // TODO(hossein): would be good to support other common timestamp formats |
Contributor
|
Thanks - I'm going to merge this. There is a tiny comment. Can you remove that comment in one of your other pr? |
Member
Author
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
… data source ## What changes were proposed in this pull request? https://issues.apache.org/jira/browse/SPARK-13899 This PR makes CSV data source produce `InternalRow` instead of `Row`. Basically, this resembles JSON data source. It uses the same codes for casting. ## How was this patch tested? Unit tests were used within IDE and code style was checked by `./dev/run_tests`. Author: hyukjinkwon <gurwls223@gmail.com> Closes apache#11717 from HyukjinKwon/SPARK-13899.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/SPARK-13899
This PR makes CSV data source produce
InternalRowinstead ofRow.Basically, this resembles JSON data source. It uses the same codes for casting.
How was this patch tested?
Unit tests were used within IDE and code style was checked by
./dev/run_tests.