[SPARK-13974][SQL] sub-query names do not need to be globally unique while generate SQL #11783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @liancheng @yhuai |
Contributor
|
LGTM |
|
Test build #53430 has finished for PR 11783 at commit
|
Contributor
|
test this please |
|
Test build #53436 has finished for PR 11783 at commit
|
Contributor
|
test this please |
|
Test build #53448 has finished for PR 11783 at commit
|
Contributor
Author
|
merging to master! |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…while generate SQL ## What changes were proposed in this pull request? We only need to make sub-query names unique every time we generate a SQL string, but not all the time. This PR moves the `newSubqueryName` method to `class SQLBuilder` and remove `object SQLBuilder`. also addressed 2 minor comments in apache#11696 ## How was this patch tested? existing tests. Author: Wenchen Fan <wenchen@databricks.com> Closes apache#11783 from cloud-fan/tmp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We only need to make sub-query names unique every time we generate a SQL string, but not all the time. This PR moves the
newSubqueryNamemethod toclass SQLBuilderand removeobject SQLBuilder.also addressed 2 minor comments in #11696
How was this patch tested?
existing tests.