-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-14088][SQL] Some Dataset API touch-up #11908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @davies for Python, and @cloud-fan / @liancheng for the rest. |
| * df.select($"colA".name("colB")) | ||
| * }}} | ||
| * | ||
| * If the current column has metadata associated with it, this metadata will be propagated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to avoid duplicating documents at scala side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no unfortunately...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, actually there is. You can use @define <name> <definition> and then reference it using $name later. See here. Scala standard library uses this trick extensively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it work with the unidoc for java?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked, unfortunately it doesn't work for Java :(
|
LGTM |
|
Test build #53866 has finished for PR 11908 at commit
|
|
LGTM for python part |
|
Test build #53886 has finished for PR 11908 at commit
|
|
Thanks - merging in master. |
What changes were proposed in this pull request?
How was this patch tested?
All changes should be covered by existing tests. Also added couple test cases to cover "name".