Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Jun 24, 2014

TODOs

  • Figure out the config option names
  • Decide whether we want to create a new interface or just reuse the existing. If user applications use the existing combineValuesByKey with the assumption the output key will be unique, this could potentially break their applications (however we never really documented what the behavior of this function should be)
  • Implement the same functionality for the external spilling case

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16050/

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16052/

@mateiz
Copy link
Contributor

mateiz commented Jul 13, 2014

A few comments on this:

  • We probably can't break the existing combineByKey through a config setting. If people want to use this directly, they'll need to use another interface. Otherwise we can have combineByKey do this on the map side but not on the reduce side.
  • Since spilling is on by default now, we should probably add an implementation for that too before merging.

@pwendell
Copy link
Contributor

pwendell commented Sep 2, 2014

@rxin this issue has gone stale. Do you mind closing this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants