Skip to content

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Mar 28, 2016

What changes were proposed in this pull request?

The indentation of debug log output by CodeGenerator is weird.
The first line of the generated code should be put on the next line of the first line of the log message.

16/03/28 11:10:24 DEBUG CodeGenerator: /* 001 */                                                                                                              
/* 002 */ public java.lang.Object generate(Object[] references) {
/* 003 */   return new SpecificSafeProjection(references); 
...

After this patch is applied, we get debug log like as follows.

16/03/28 10:45:50 DEBUG CodeGenerator:                                                 
/* 001 */ 
/* 002 */ public java.lang.Object generate(Object[] references) {
/* 003 */   return new SpecificSafeProjection(references);
...

How was this patch tested?

Ran some jobs and checked debug logs.

@SparkQA
Copy link

SparkQA commented Mar 28, 2016

Test build #54292 has finished for PR 11990 at commit 49ac4c8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Mar 28, 2016

Thanks - merging in master.

@asfgit asfgit closed this in aac13fb Mar 28, 2016
@sarutak sarutak deleted the fix-debuglog-indentation branch April 12, 2016 13:58
ghost pushed a commit to dbtsai/spark that referenced this pull request May 5, 2016
…ted with proper indentation

## What changes were proposed in this pull request?

Similar to apache#11990, GenerateOrdering and GenerateColumnAccessor should print debug log for generated code with proper indentation.

## How was this patch tested?

Manually checked.

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>

Closes apache#12908 from sarutak/SPARK-15132.
asfgit pushed a commit that referenced this pull request May 5, 2016
…ted with proper indentation

## What changes were proposed in this pull request?

Similar to #11990, GenerateOrdering and GenerateColumnAccessor should print debug log for generated code with proper indentation.

## How was this patch tested?

Manually checked.

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>

Closes #12908 from sarutak/SPARK-15132.

(cherry picked from commit 1a9b341)
Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants