Skip to content

[SPARK-14339][DOC] Add python examples for DCT,MinMaxScaler,MaxAbsScaler #12063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zhengruifeng wants to merge 4 commits into from
Closed

[SPARK-14339][DOC] Add python examples for DCT,MinMaxScaler,MaxAbsScaler #12063

zhengruifeng wants to merge 4 commits into from

Conversation

@zhengruifeng
Copy link
Contributor

@zhengruifeng zhengruifeng commented Mar 30, 2016

What changes were proposed in this pull request?

add three python examples

How was this patch tested?

manual tests

@SparkQA
Copy link

SparkQA commented Mar 30, 2016

Test build #54514 has finished for PR 12063 at commit 925c97a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

yanboliang
yanboliang reviewed Mar 30, 2016
View reviewed changes
examples/src/main/python/ml/dct_example.py Outdated
.createDataFrame([(Vectors.dense([0.0, 1.0, -2.0, 3.0]),),
(Vectors.dense([-1.0, 2.0, 4.0, -7.0]),),
(Vectors.dense([14.0, -2.0, -5.0, 1.0]),)],
["features"])
Copy link
Contributor

@yanboliang yanboliang Mar 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Better code format, you can refer here.

Copy link
Contributor Author

@zhengruifeng zhengruifeng Mar 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I will fix it

@yanboliang
Copy link
Contributor

yanboliang commented Mar 30, 2016

LGTM except minor issue.

@SparkQA
Copy link

SparkQA commented Mar 31, 2016

Test build #54611 has finished for PR 12063 at commit e374e58.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Apr 1, 2016

@zhengruifeng Could you make JIRAs for this PR and #11844? [MINOR] is only used for apparent typo fixes or trivial changes.

@zhengruifeng
Copy link
Contributor Author

zhengruifeng commented Apr 2, 2016

@mengxr Ok, I will open the missing JIRAs

@zhengruifeng zhengruifeng changed the title [Minor][DOC] Add python examples for DCT,MinMaxScaler,MaxAbsScaler [SPARK-14339][DOC] Add python examples for DCT,MinMaxScaler,MaxAbsScaler Apr 2, 2016
@yanboliang
Copy link
Contributor

yanboliang commented Apr 8, 2016

LGTM

@zhengruifeng
Copy link
Contributor Author

zhengruifeng commented Apr 9, 2016

cc @jkbradley

@mengxr
Copy link
Contributor

mengxr commented Apr 9, 2016

Merged into master. Thanks!

@asfgit asfgit closed this in adb9d73 Apr 9, 2016
@zhengruifeng zhengruifeng deleted the dct_pe branch April 10, 2016 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhengruifeng @SparkQA @yanboliang @mengxr