[SPARK-14310] Fix scan whole stage codegen to support batches without runtime check. #12098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… runtime check. Currently, we determine if the RDD will produce batches or rows by looking at the first value. After other clean ups, this is not necessary anymore. This simplifies the code and let's us measure time spent in the first batch.
| |if ($input.hasNext()) { | ||
| | $scanRows((InternalRow) $input.next()); | ||
| |} | ||
| | while (!shouldStop() && $input.hasNext()) { |
Member
There was a problem hiding this comment.
Should we put !shouldStop() into the end of the while-loop to avoid performance degradation?
Contributor
Author
There was a problem hiding this comment.
I tried a few variants and didn't see a difference. I think only the batched scan is fast enough to be sensitive to this.
Member
There was a problem hiding this comment.
I see. Thank you for your information. A result of the experiments is useful. It may be good to leave the result in a comment.
|
Test build #54666 has finished for PR 12098 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, we determine if the RDD will produce batches or rows by looking at the first
value. After other clean ups, this is not necessary anymore. This simplifies the code
and let's us measure time spent in the first batch.