Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Mar 31, 2016

What changes were proposed in this pull request?

RpcEndpoint is not thread safe and allows multiple messages to be processed at the same time. StateStoreCoordinator should use ThreadSafeRpcEndpoint.

How was this patch tested?

Existing unit tests.

RpcEndpoint is not thread safe and allows multiple messages to be processed at the same time. StateStoreCoordinator should use ThreadSafeRpcEndpoint.
@SparkQA
Copy link

SparkQA commented Apr 1, 2016

Test build #54670 has finished for PR 12100 at commit b949883.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tdas
Copy link
Contributor

tdas commented Apr 1, 2016

Going to run multiple tests on this. LGTM otherwise.

@andrewor14
Copy link
Contributor

deep-review this please

@DeepSparkBot
Copy link

@andrewor14 Review complete. LGTM.

@zsxwing
Copy link
Member Author

zsxwing commented Apr 1, 2016

@andrewor14 Review complete. LGTM.

Cool!

@SparkQA
Copy link

SparkQA commented Apr 1, 2016

Test build #2725 has finished for PR 12100 at commit b949883.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 1, 2016

Test build #2726 has finished for PR 12100 at commit b949883.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 1, 2016

Test build #2724 has finished for PR 12100 at commit b949883.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member Author

zsxwing commented Apr 1, 2016

Since all tests passed, I'm going to merge to master. Thanks, @tdas @andrewor14 and @DeepSparkBot :)

@asfgit asfgit closed this in 0b7d496 Apr 1, 2016
@zsxwing zsxwing deleted the fix-StateStoreCoordinator branch April 1, 2016 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants