[SPARK-14396] [SQL] Throw Exceptions for DDLs of Partitioned Views

[gatorsmile]

What changes were proposed in this pull request?

Because the concept of partitioning is associated with physical tables, we disable all the supports of partitioned views, which are defined in the following three commands in Hive DDL Manual:

ALTER VIEW view DROP [IF EXISTS] PARTITION spec1[, PARTITION spec2, ...];

ALTER VIEW view ADD [IF NOT EXISTS] PARTITION spec;

CREATE VIEW [IF NOT EXISTS] [db_name.]view_name [(column_name [COMMENT column_comment], ...) ]
  [COMMENT view_comment]
  [TBLPROPERTIES (property_name = property_value, ...)]
  AS SELECT ...;

An exception is thrown when users issue any of these three DDL commands.

How was this patch tested?

Added test cases for parsing create view and changed the existing test cases to verify if the exceptions are thrown.

[hvanhovell]

Minor: we don't really need kind. We can also just check for the existance of the VIEW keyword, e.g.: ctx.VIEW != null.

[gatorsmile]

Thanks! Will do.

[SparkQA]

Test build #54959 has finished for PR 12169 at commit b6c1601.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #54983 has finished for PR 12169 at commit 140f859.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[gatorsmile]

Thanks for the review! @hvanhovell

Also cc @yhuai @andrewor14

[andrewor14]

I think @yhuai prefers to say something like Operation not allowed: partitioned views for the message (here and everywhere else)

[gatorsmile]

Will do it now. Thanks!

[andrewor14]

Looks pretty good, just a minor comment.

[gatorsmile]

retest this please

[SparkQA]

Test build #55031 has finished for PR 12169 at commit e5a8de7.

• This patch fails to build.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • s\"its class is $
  • s\"Unable to generate an encoder for inner class$`
  • case class UnresolvedGenerator(name: String, children: Seq[Expression]) extends Generator
  • case class UnresolvedDeserializer(deserializer: Expression, inputAttributes: Seq[Attribute])
  • case class FunctionResource(resourceType: FunctionResourceType, uri: String)
  • trait FunctionResourceLoader
  • case class CatalogFunction(
  • case class CreateFunction(
  • case class DropFunction(
  • case class StreamingRelation(dataSource: DataSource, sourceName: String, output: Seq[Attribute])
  • case class StreamingExecutionRelation(source: Source, output: Seq[Attribute]) extends LeafNode

[andrewor14]

Build is broken I think. retest this please

[andrewor14]

this needs to be deleted

[andrewor14]

LGTM we just need to make tests pass now

[SparkQA]

Test build #55049 has finished for PR 12169 at commit e5a8de7.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • s\"its class is $
  • s\"Unable to generate an encoder for inner class$`
  • case class UnresolvedGenerator(name: String, children: Seq[Expression]) extends Generator
  • case class UnresolvedDeserializer(deserializer: Expression, inputAttributes: Seq[Attribute])
  • case class FunctionResource(resourceType: FunctionResourceType, uri: String)
  • trait FunctionResourceLoader
  • case class CatalogFunction(
  • case class CreateFunction(
  • case class DropFunction(
  • case class StreamingRelation(dataSource: DataSource, sourceName: String, output: Seq[Attribute])
  • case class StreamingExecutionRelation(source: Source, output: Seq[Attribute]) extends LeafNode

[SparkQA]

Test build #55072 has finished for PR 12169 at commit 93e51b4.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[andrewor14]

Merged into master.

[yhuai]

@gatorsmile Seems scala 2.10 build is broken. Can you take a look?

[gatorsmile]

Sure. Could you show me how to find the build log?

[gatorsmile]

Or I need to do it in my local environment?

[gatorsmile]

https://amplab.cs.berkeley.edu/jenkins/job/spark-master-compile-maven-scala-2.10/ ?

[gatorsmile]

I see the problem.

[error] /home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:266: value contains is not a member of Option[String]
[error]     assert(desc.viewText.contains("SELECT * FROM tab1"))
[error]                          ^
[error] /home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:267: value contains is not a member of Option[String]
[error]     assert(desc.viewOriginalText.contains("SELECT * FROM tab1"))
[error]                                  ^
[error] /home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:293: value contains is not a member of Option[String]
[error]     assert(desc.viewText.contains("SELECT * FROM tab1"))
[error]                          ^
[error] /home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:294: value contains is not a member of Option[String]
[error]     assert(desc.viewOriginalText.contains("SELECT * FROM tab1"))
[error]                                  ^
[error] four errors found
[error] Compile failed at Apr 5, 2016 10:59:09 PM [10.502s]

[gatorsmile]

Will fix it using a PR with [HOT]. Sorry for it.