[SPARK-14512][DOC] Add python example for QuantileDiscretizer #12281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #55463 has finished for PR 12281 at commit
|
Contributor
|
Looks good to me, confirmed the example runs as expected. |
Contributor
|
cc @davies ? |
Contributor
There was a problem hiding this comment.
Examples have been updated to use SparkSession, see e.g. https://github.com/apache/spark/blob/master/examples/src/main/python/ml/binarizer_example.py.
Also, there is a PR to indent the builder pattern #12911 so you should follow that style (also refer #12809)
Contributor
|
@zhengruifeng sorry for the delay. The core of the example looks good, it just now needs to be updated to use |
Contributor
Author
|
@MLnick Updated. Thanks for review this. |
|
Test build #57882 has finished for PR 12281 at commit
|
Contributor
|
LGTM. Thanks! |
Contributor
|
Merging this into master and 2.0, thanks! |
asfgit
pushed a commit
that referenced
this pull request
May 6, 2016
## What changes were proposed in this pull request? Add the missing python example for QuantileDiscretizer ## How was this patch tested? manual tests Author: Zheng RuiFeng <ruifengz@foxmail.com> Closes #12281 from zhengruifeng/discret_pe. (cherry picked from commit 76ad04d) Signed-off-by: Davies Liu <davies.liu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the missing python example for QuantileDiscretizer
How was this patch tested?
manual tests