Skip to content

[SPARK-14589][SQL] Enhance DB2 JDBC Dialect docker tests #12348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lresende wants to merge 2 commits into from
Closed

[SPARK-14589][SQL] Enhance DB2 JDBC Dialect docker tests #12348

lresende wants to merge 2 commits into from

Conversation

@lresende
Copy link
Member

@lresende lresende commented Apr 13, 2016

What changes were proposed in this pull request?

Enhance the DB2 JDBC Dialect docker tests as they seemed to have had some issues on previous merge causing some tests to fail.

How was this patch tested?

By running the integration tests locally.

@SparkQA
Copy link

SparkQA commented Apr 13, 2016

Test build #55681 has finished for PR 12348 at commit 1f9d6fe.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • assert(types(0).equals(\"class java.lang.Integer\"))
    • assert(types(1).equals(\"class java.lang.Integer\"))
    • assert(types(2).equals(\"class java.lang.Long\"))
    • assert(types(3).equals(\"class java.math.BigDecimal\"))
    • assert(types(4).equals(\"class java.lang.Double\"))
    • assert(types(5).equals(\"class java.lang.Double\"))
    • assert(types(3).equals(\"class [B\"))

@SparkQA
Copy link

SparkQA commented Apr 13, 2016

Test build #55690 has finished for PR 12348 at commit 7250fce.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • assert(types(0).equals(\"class java.lang.Integer\"))
    • assert(types(1).equals(\"class java.lang.Integer\"))
    • assert(types(2).equals(\"class java.lang.Long\"))
    • assert(types(3).equals(\"class java.math.BigDecimal\"))
    • assert(types(4).equals(\"class java.lang.Double\"))
    • assert(types(5).equals(\"class java.lang.Double\"))
    • assert(types(3).equals(\"class [B\"))

@lresende
Copy link
Member Author

lresende commented Apr 13, 2016

@JoshRosen please review, these are the merge issues I mentioned yesterday, and these changes are passing my local tests as well.

lresende referenced this pull request Apr 14, 2016
@lresende @JoshRosen
[SPARK-10521][SQL] Utilize Docker for test DB2 JDBC Dialect support
94de630 
Add integration tests based on docker to test DB2 JDBC dialect support

Author: Luciano Resende <lresende@apache.org>

Closes #9893 from lresende/SPARK-10521.
@SparkQA
Copy link

SparkQA commented Apr 14, 2016

Test build #55787 has finished for PR 12348 at commit b3e2a4f.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@lresende
Copy link
Member Author

lresende commented Apr 14, 2016

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Apr 14, 2016

Test build #55789 has finished for PR 12348 at commit b3e2a4f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 18, 2016

Test build #56143 has finished for PR 12348 at commit 47e2810.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

JoshRosen commented Apr 18, 2016

Can you fix scalastyle?

@SparkQA
Copy link

SparkQA commented Apr 19, 2016

Test build #56156 has finished for PR 12348 at commit ab950db.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@lresende
Copy link
Member Author

lresende commented Apr 19, 2016

@JoshRosen All good now.

@lresende
Copy link
Member Author

lresende commented Apr 21, 2016

@JoshRosen ping

@srowen
Copy link
Member

srowen commented May 3, 2016

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented May 3, 2016

Test build #57631 has finished for PR 12348 at commit ab950db.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@lresende lresende mentioned this pull request May 4, 2016
Closed
@SparkQA
Copy link

SparkQA commented May 4, 2016

Test build #57797 has finished for PR 12348 at commit 83ac475.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented May 5, 2016

This test is ignored now anyway, and given @lresende 's confidence this actually gets it working, LGTM

asfgit pushed a commit that referenced this pull request May 5, 2016
@lresende @srowen
[SPARK-14589][SQL] Enhance DB2 JDBC Dialect docker tests
666eb01 
## What changes were proposed in this pull request?

Enhance the DB2 JDBC Dialect docker tests as they seemed to have had some issues on previous merge causing some tests to fail.

## How was this patch tested?

By running the integration tests locally.

Author: Luciano Resende <lresende@apache.org>

Closes #12348 from lresende/SPARK-14589.

(cherry picked from commit 1044302)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen
Copy link
Member

srowen commented May 5, 2016

Merged to master/2.0

@asfgit asfgit closed this in 1044302 May 5, 2016
asfgit pushed a commit that referenced this pull request May 6, 2016
@lresende @srowen
[SPARK-14738][BUILD] Separate docker integration tests from main build
a03c5e6 
## What changes were proposed in this pull request?

Create a maven profile for executing the docker integration tests using maven
Remove docker integration tests from main sbt build
Update documentation on how to run docker integration tests from sbt

## How was this patch tested?

Manual test of the docker integration tests as in :
mvn -Pdocker-integration-tests -pl :spark-docker-integration-tests_2.11 compile test

## Other comments

Note that the the DB2 Docker Tests are still disabled as there is a kernel version issue on the AMPLab Jenkins slaves and we would need to get them on the right level before enabling those tests. They do run ok locally with the updates from PR #12348

Author: Luciano Resende <lresende@apache.org>

Closes #12508 from lresende/docker.
asfgit pushed a commit that referenced this pull request May 6, 2016
@lresende @srowen
[SPARK-14738][BUILD] Separate docker integration tests from main build
1ee621b 
## What changes were proposed in this pull request?

Create a maven profile for executing the docker integration tests using maven
Remove docker integration tests from main sbt build
Update documentation on how to run docker integration tests from sbt

## How was this patch tested?

Manual test of the docker integration tests as in :
mvn -Pdocker-integration-tests -pl :spark-docker-integration-tests_2.11 compile test

## Other comments

Note that the the DB2 Docker Tests are still disabled as there is a kernel version issue on the AMPLab Jenkins slaves and we would need to get them on the right level before enabling those tests. They do run ok locally with the updates from PR #12348

Author: Luciano Resende <lresende@apache.org>

Closes #12508 from lresende/docker.

(cherry picked from commit a03c5e6)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@lresende lresende deleted the SPARK-14589 branch May 7, 2016 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lresende @SparkQA @JoshRosen @srowen