[SPARK-14619] Track internal accumulators (metrics) by stage attempt #12378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rather than stage
|
Test build #55776 has finished for PR 12378 at commit
|
Contributor
Author
|
cc @andrewor14 |
| * | ||
| * This is called every time the stage is submitted, *except* when a subset of tasks | ||
| * belonging to this stage has already finished. Otherwise, reinitializing the internal | ||
| * accumulators here again will override partial values from the finished tasks. |
Member
There was a problem hiding this comment.
Don't we need to care about the overriding problem as mentioned here?
Contributor
Author
There was a problem hiding this comment.
The whole point of this change is to split them into separate accumulators so we don't need to worry about overrides.
Contributor
|
LGTM merging into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When there are multiple attempts for a stage, we currently only reset internal accumulator values if all the tasks are resubmitted. It would make more sense to reset the accumulator values for each stage attempt. This will allow us to eventually get rid of the internal flag in the Accumulator class. This is part of my bigger effort to simplify accumulators and task metrics.
How was this patch tested?
Covered by existing tests.