-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-14712][ML]spark.ml.LogisticRegressionModel.toString should sum… #12491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -273,6 +273,10 @@ def evaluate(self, dataset): | |
| java_blr_summary = self._call_java("evaluate", dataset) | ||
| return BinaryLogisticRegressionSummary(java_blr_summary) | ||
|
|
||
| @since("2.0.0") | ||
| def __repr__(self): | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It might make sense to include this in the docstring since it might be useful for people to see how to use it :) |
||
| return self._call_java("toString") | ||
|
|
||
|
|
||
| class LogisticRegressionSummary(JavaWrapper): | ||
| """ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -262,6 +262,10 @@ def load(cls, sc, path): | |
| model.setThreshold(threshold) | ||
| return model | ||
|
|
||
| @since("2.0.0") | ||
| def __repr__(self): | ||
| return self._call_java("toString") | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think Python style asks for two new lines here (try running ./dev/lint-python locally :))
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok :) |
||
|
|
||
| class LogisticRegressionWithSGD(object): | ||
| """ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to update this since :)