[SPARK-2169] Don't copy appName / basePath everywhere. #1252

vanzin · 2014-06-27T22:18:53Z

Instead of keeping copies in all pages, just reference the values
kept in the base SparkUI instance (by making them available via
getters).

vanzin · 2014-06-27T22:19:29Z

Tested on top of #1218 and verified app name looks like what I'd expect from the code.

AmplabJenkins · 2014-06-27T22:20:28Z

Can one of the admins verify this patch?

vanzin · 2014-08-04T18:44:24Z

Friendly ping.

vanzin · 2014-08-04T18:44:40Z

Jenkins, test this please.

Instead of keeping copies in all pages, just reference the values kept in the base SparkUI instance (by making them available via getters).

vanzin · 2014-08-07T16:24:45Z

Another friendly ping.

pwendell · 2014-08-08T05:22:23Z

Hey @andrewor14 - can you take a look at this one? seems pretty straightforward, though I'm not super familiar with this code.

andrewor14 · 2014-08-08T05:29:33Z

test this please

SparkQA · 2014-08-08T05:34:32Z

QA tests have started for PR 1252. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18189/consoleFull

SparkQA · 2014-08-08T06:26:39Z

QA results for PR 1252:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18189/consoleFull

andrewor14 · 2014-08-08T20:40:52Z

core/src/main/scala/org/apache/spark/ui/SparkUI.scala

does this fit in the line above?

Not completely.

andrewor14 · 2014-08-08T20:52:29Z

@vanzin Thanks for your PR. These are pretty straightforward changes, and I left a couple of minor comments. Otherwise this LGTM.

Also some other cleanup.

vanzin · 2014-08-12T21:24:29Z

Ping.

andrewor14 · 2014-08-12T21:48:51Z

Sorry @vanzin I've been caught up with another bug that we're still debugging at the moment. I will look at this and the app ID patch some time tomorrow if not today.

andrewor14 · 2014-08-14T04:49:17Z

Looks great. Thanks @vanzin

vanzin · 2014-08-18T16:50:52Z

Hi, could we get this merged if there's no more feedback? Thanks!

pwendell · 2014-08-18T18:01:27Z

Jenkins retest this please. LGTM pending tests.

pwendell · 2014-08-18T19:12:01Z

Jenkins, test this please.

SparkQA · 2014-08-18T19:15:39Z

QA tests have started for PR 1252 at commit 4412fc6.

This patch merges cleanly.

SparkQA · 2014-08-18T20:09:38Z

QA tests have finished for PR 1252 at commit 4412fc6.

This patch passes unit tests.
This patch merges cleanly.
This patch adds no public classes.

andrewor14 · 2014-08-18T20:25:51Z

Thanks, I've merged this.

Instead of keeping copies in all pages, just reference the values kept in the base SparkUI instance (by making them available via getters). Author: Marcelo Vanzin <vanzin@cloudera.com> Closes #1252 from vanzin/SPARK-2169 and squashes the following commits: 4412fc6 [Marcelo Vanzin] Simplify UIUtils.headerSparkPage signature. 4e5d35a [Marcelo Vanzin] [SPARK-2169] Don't copy appName / basePath everywhere.

Instead of keeping copies in all pages, just reference the values kept in the base SparkUI instance (by making them available via getters). Author: Marcelo Vanzin <vanzin@cloudera.com> Closes apache#1252 from vanzin/SPARK-2169 and squashes the following commits: 4412fc6 [Marcelo Vanzin] Simplify UIUtils.headerSparkPage signature. 4e5d35a [Marcelo Vanzin] [SPARK-2169] Don't copy appName / basePath everywhere.

…on (apache#1252) ### What changes were proposed in this pull request? This PR cherry-picks the ordering and distribution during table creation to 3.2. The same syntax is supported in 3.0 and 3.1. ### Why are the changes needed? These changes are needed to define a sort key and distribution in Iceberg tables. ### Does this PR introduce _any_ user-facing change? Yes but the changes won't affect anyone except Iceberg users. ### How was this patch tested? This PR comes with tests.

…nNumPartitions (#1252)

…pache#1252)

[SPARK-2169] Don't copy appName / basePath everywhere.

4e5d35a

Instead of keeping copies in all pages, just reference the values kept in the base SparkUI instance (by making them available via getters).

andrewor14 reviewed Aug 8, 2014
View reviewed changes

Simplify UIUtils.headerSparkPage signature.

4412fc6

Also some other cleanup.

asfgit closed this in 66ade00 Aug 18, 2014

vanzin deleted the SPARK-2169 branch August 18, 2014 21:20

andrewor14 mentioned this pull request Sep 2, 2014

[SPARK-3388] Expose aplication ID in ApplicationStart event, use it in history server. #1218

Closed

wangyum pushed a commit that referenced this pull request May 26, 2023

[CARMEL-6586] Ignore SinglePartition when determining expectedChildre…

9e899c1

…nNumPartitions (#1252)

mapr-devops pushed a commit to mapr/spark that referenced this pull request May 8, 2025

MapR [SPARK-1364] Check if SSO is enabled on cluster for login page (a…

6a71ab5

…pache#1252)

[SPARK-2169] Don't copy appName / basePath everywhere. #1252

[SPARK-2169] Don't copy appName / basePath everywhere. #1252

Uh oh!

Conversation

vanzin commented Jun 27, 2014

Uh oh!

vanzin commented Jun 27, 2014

Uh oh!

AmplabJenkins commented Jun 27, 2014

Uh oh!

vanzin commented Aug 4, 2014

Uh oh!

vanzin commented Aug 4, 2014

Uh oh!

vanzin commented Aug 7, 2014

Uh oh!

pwendell commented Aug 8, 2014

Uh oh!

andrewor14 commented Aug 8, 2014

Uh oh!

SparkQA commented Aug 8, 2014

Uh oh!

SparkQA commented Aug 8, 2014

Uh oh!

andrewor14 Aug 8, 2014

Choose a reason for hiding this comment

Uh oh!

vanzin Aug 8, 2014

Choose a reason for hiding this comment

Uh oh!

andrewor14 commented Aug 8, 2014

Uh oh!

vanzin commented Aug 12, 2014

Uh oh!

andrewor14 commented Aug 12, 2014

Uh oh!

andrewor14 commented Aug 14, 2014

Uh oh!

vanzin commented Aug 18, 2014

Uh oh!

pwendell commented Aug 18, 2014

Uh oh!

pwendell commented Aug 18, 2014

Uh oh!

SparkQA commented Aug 18, 2014

Uh oh!

SparkQA commented Aug 18, 2014

Uh oh!

andrewor14 commented Aug 18, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants