-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-14434][ML]:User guide doc and examples for GaussianMixture in spark.ml #12788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #57363 has finished for PR 12788 at commit
|
docs/ml-clustering.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The MLlib" -> "The spark.ml"
|
I made a pass. @zhengruifeng can you please take a look as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outer println is unnecessary
|
@sethah It seems that these examples follow |
|
Test build #58009 has finished for PR 12788 at commit
|
|
retest it please. |
|
Test build #58020 has finished for PR 12788 at commit
|
|
@sethah @zhengruifeng @yanboliang I made changes to address comments. |
|
retest this please |
|
Test build #58033 has finished for PR 12788 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: "Creates"
|
Test build #58512 has finished for PR 12788 at commit
|
|
Test build #58514 has finished for PR 12788 at commit
|
|
@yanboliang @MLnick @zhengruifeng @sethah simplified the example using kmeans data and addressed review comments. |
|
Test build #58522 has finished for PR 12788 at commit
|
|
Test build #58523 has finished for PR 12788 at commit
|
docs/ml-clustering.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python API docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, j -> 'i' to keep in line with scala example
|
Test build #58546 has finished for PR 12788 at commit
|
|
@wangmiao1981 could you resolve merge conflicts by rebasing to master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do setSeed here in the Python example but not in the Scala/Java examples. We should make it consistent (perhaps remove the setSeed here)
|
A few other minor comments, otherwise LGTM |
|
Test build #58645 has finished for PR 12788 at commit
|
|
@MLnick I made changes accordingly. Thanks! |
…spark.ml ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) Add guide doc and examples for GaussianMixture in Spark.ml in Java, Scala and Python. ## How was this patch tested? (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) Manual compile and test all examples Author: wm624@hotmail.com <wm624@hotmail.com> Closes #12788 from wangmiao1981/example. (cherry picked from commit 4134ff0) Signed-off-by: Nick Pentreath <nickp@za.ibm.com>
|
Merged to master/branch-2.0. Thanks @sethah @zhengruifeng for the review! |
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Add guide doc and examples for GaussianMixture in Spark.ml in Java, Scala and Python.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Manual compile and test all examples