Skip to content

Conversation

@wangmiao1981
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

Add guide doc and examples for GaussianMixture in Spark.ml in Java, Scala and Python.

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

Manual compile and test all examples

@SparkQA
Copy link

SparkQA commented Apr 29, 2016

Test build #57363 has finished for PR 12788 at commit 03ac9b4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangmiao1981
Copy link
Contributor Author

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The MLlib" -> "The spark.ml"

@sethah
Copy link
Contributor

sethah commented May 4, 2016

I made a pass. @zhengruifeng can you please take a look as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outer println is unnecessary

@zhengruifeng
Copy link
Contributor

@sethah It seems that these examples follow ml.kmeans's examples.
I agreed that it's better to keep in line with mllib's, especially the output information.

@SparkQA
Copy link

SparkQA commented May 6, 2016

Test build #58009 has finished for PR 12788 at commit c844a6e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangmiao1981
Copy link
Contributor Author

retest it please.

@SparkQA
Copy link

SparkQA commented May 6, 2016

Test build #58020 has finished for PR 12788 at commit 4b5152a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangmiao1981
Copy link
Contributor Author

@sethah @zhengruifeng @yanboliang I made changes to address comments.

@wangmiao1981
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented May 6, 2016

Test build #58033 has finished for PR 12788 at commit 4b5152a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "Creates"

@SparkQA
Copy link

SparkQA commented May 12, 2016

Test build #58512 has finished for PR 12788 at commit aaea542.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 12, 2016

Test build #58514 has finished for PR 12788 at commit 8f6f78f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangmiao1981
Copy link
Contributor Author

@yanboliang @MLnick @zhengruifeng @sethah simplified the example using kmeans data and addressed review comments.

@SparkQA
Copy link

SparkQA commented May 12, 2016

Test build #58522 has finished for PR 12788 at commit 7175a1d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 12, 2016

Test build #58523 has finished for PR 12788 at commit 5259d4d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python API docs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, j -> 'i' to keep in line with scala example

@SparkQA
Copy link

SparkQA commented May 13, 2016

Test build #58546 has finished for PR 12788 at commit eb9469e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangmiao1981
Copy link
Contributor Author

@MLnick
Copy link
Contributor

MLnick commented May 16, 2016

@wangmiao1981 could you resolve merge conflicts by rebasing to master?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do setSeed here in the Python example but not in the Scala/Java examples. We should make it consistent (perhaps remove the setSeed here)

@MLnick
Copy link
Contributor

MLnick commented May 16, 2016

A few other minor comments, otherwise LGTM

@SparkQA
Copy link

SparkQA commented May 16, 2016

Test build #58645 has finished for PR 12788 at commit f56344b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangmiao1981
Copy link
Contributor Author

@MLnick I made changes accordingly. Thanks!

asfgit pushed a commit that referenced this pull request May 17, 2016
…spark.ml

## What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

Add guide doc and examples for GaussianMixture in Spark.ml in Java, Scala and Python.

## How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

Manual compile and test all examples

Author: wm624@hotmail.com <wm624@hotmail.com>

Closes #12788 from wangmiao1981/example.

(cherry picked from commit 4134ff0)
Signed-off-by: Nick Pentreath <nickp@za.ibm.com>
@MLnick
Copy link
Contributor

MLnick commented May 17, 2016

Merged to master/branch-2.0. Thanks @sethah @zhengruifeng for the review!

@asfgit asfgit closed this in 4134ff0 May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants