Skip to content

[SPARK-15057][GRAPHX] Remove stale TODO comment for making enum in GraphGenerators #12839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 2 commits into from
Closed

[SPARK-15057][GRAPHX] Remove stale TODO comment for making enum in GraphGenerators #12839

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6dc967
[SPARK-15057][GRAPHX] Use enum Quadrant in GraphGenerators
dongjoon-hyun May 2, 2016
dd9b008
Remove only TODO comment.
dongjoon-hyun May 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion graphx/src/main/scala/org/apache/spark/graphx/util/GraphGenerators.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ object GraphGenerators extends Logging {
}
}

// TODO(crankshaw) turn result into an enum (or case class for pattern matching}
private def pickQuadrant(a: Double, b: Double, c: Double, d: Double): Int = {
if (a + b + c + d != 1.0) {
throw new IllegalArgumentException("R-MAT probability parameters sum to " + (a + b + c + d)
Expand Down