-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-14900][ML]:spark.ml classification metrics should include accuracy #12882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #57680 has finished for PR 12882 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment on JIRA; we might even deprecate precision?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srowen Thanks for your review! I think it makes a lot sense of deprecating "precision" with "accuracy" as I got confused when I tried to add accuracy yesterday. I will make the changes.
|
Test build #57776 has finished for PR 12882 at commit
|
|
Test build #57777 has finished for PR 12882 at commit
|
|
Test build #57848 has finished for PR 12882 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to leave the @Since annotation though. I might also not say it will be removed for sure in 2.1. May be removed.
|
Test build #57917 has finished for PR 12882 at commit
|
|
Test build #57918 has finished for PR 12882 at commit
|
|
@srowen Any comments on the change? Thanks! |
|
I think this is OK as a 'rename'. I wouldn't mind hearing from @mengxr as a double check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @wangmiao1981 can we do one more thing -- let's have all the deprecated methods call accuracy. Right now this (simple) expression is duplicated. And, note in precision's docs that it equals accuracy.
|
@srowen I will make the suggested changes. Thanks! |
|
Test build #58515 has finished for PR 12882 at commit
|
|
@srowen I have made the changes. Thanks! |
|
Merged to master/2.0 |
…racy ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) Add accuracy to MulticlassMetrics class and add corresponding code in MulticlassClassificationEvaluator. ## How was this patch tested? (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) Scala Unit tests in ml.evaluation Author: wm624@hotmail.com <wm624@hotmail.com> Closes #12882 from wangmiao1981/accuracy. (cherry picked from commit bdff299) Signed-off-by: Sean Owen <sowen@cloudera.com>
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Add accuracy to MulticlassMetrics class and add corresponding code in MulticlassClassificationEvaluator.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Scala Unit tests in ml.evaluation