Skip to content

Conversation

@wangmiao1981
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)
Add accuracy to MulticlassMetrics class and add corresponding code in MulticlassClassificationEvaluator.

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Scala Unit tests in ml.evaluation

@SparkQA
Copy link

SparkQA commented May 3, 2016

Test build #57680 has finished for PR 12882 at commit e7202ba.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on JIRA; we might even deprecate precision?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srowen Thanks for your review! I think it makes a lot sense of deprecating "precision" with "accuracy" as I got confused when I tried to add accuracy yesterday. I will make the changes.

@SparkQA
Copy link

SparkQA commented May 4, 2016

Test build #57776 has finished for PR 12882 at commit 46ba842.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • * (equals to accuracy for multiclass classifier

@SparkQA
Copy link

SparkQA commented May 4, 2016

Test build #57777 has finished for PR 12882 at commit 42d7f3d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 5, 2016

Test build #57848 has finished for PR 12882 at commit 5b7a7fd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen May 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to leave the @Since annotation though. I might also not say it will be removed for sure in 2.1. May be removed.

@SparkQA
Copy link

SparkQA commented May 5, 2016

Test build #57917 has finished for PR 12882 at commit ac66a7a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 5, 2016

Test build #57918 has finished for PR 12882 at commit f511982.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • * (equals to precision for multiclass classifier

@wangmiao1981
Copy link
Contributor Author

@srowen Any comments on the change? Thanks!

@srowen
Copy link
Member

srowen commented May 10, 2016

I think this is OK as a 'rename'. I wouldn't mind hearing from @mengxr as a double check

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @wangmiao1981 can we do one more thing -- let's have all the deprecated methods call accuracy. Right now this (simple) expression is duplicated. And, note in precision's docs that it equals accuracy.

@wangmiao1981
Copy link
Contributor Author

@srowen I will make the suggested changes.

Thanks!

@SparkQA
Copy link

SparkQA commented May 12, 2016

Test build #58515 has finished for PR 12882 at commit 11132db.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangmiao1981
Copy link
Contributor Author

@srowen I have made the changes. Thanks!

@srowen
Copy link
Member

srowen commented May 13, 2016

Merged to master/2.0

@asfgit asfgit closed this in bdff299 May 13, 2016
asfgit pushed a commit that referenced this pull request May 13, 2016
…racy

## What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)
Add accuracy to MulticlassMetrics class and add corresponding code in MulticlassClassificationEvaluator.

## How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Scala Unit tests in ml.evaluation

Author: wm624@hotmail.com <wm624@hotmail.com>

Closes #12882 from wangmiao1981/accuracy.

(cherry picked from commit bdff299)
Signed-off-by: Sean Owen <sowen@cloudera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants