[SPARK-15126][SQL] RuntimeConfig.set should return Unit #12902
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…untimeConfig itself
Contributor
Author
|
cc @andrewor14 |
| """User-facing configuration API, accessible through `SparkSession.conf`. | ||
| Options set here are automatically propagated to the Hadoop configuration during I/O. | ||
| This a thin wrapper around its Scala implementation org.apache.spark.sql.RuntimeConfig. |
Contributor
Author
There was a problem hiding this comment.
this is not documentation relevant to the end user.
Contributor
There was a problem hiding this comment.
I added this actually. Let's remove it.
|
Test build #57778 has finished for PR 12902 at commit
|
Contributor
|
Merging into master 2.0 |
asfgit
pushed a commit
that referenced
this pull request
May 4, 2016
## What changes were proposed in this pull request? Currently we return RuntimeConfig itself to facilitate chaining. However, it makes the output in interactive environments (e.g. notebooks, scala repl) weird because it'd show the response of calling set as a RuntimeConfig itself. ## How was this patch tested? Updated unit tests. Author: Reynold Xin <rxin@databricks.com> Closes #12902 from rxin/SPARK-15126. (cherry picked from commit 6ae9fc0) Signed-off-by: Andrew Or <andrew@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently we return RuntimeConfig itself to facilitate chaining. However, it makes the output in interactive environments (e.g. notebooks, scala repl) weird because it'd show the response of calling set as a RuntimeConfig itself.
How was this patch tested?
Updated unit tests.