Skip to content

[SPARK-15122][SQL] Fix TPC-DS 41 - Normalize predicates before pulling them out #12954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hvanhovell wants to merge 5 commits into from
Closed

[SPARK-15122][SQL] Fix TPC-DS 41 - Normalize predicates before pulling them out #12954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f0871c9
Fix TPC-DS 41 - normalize predicates before pulling them out.
hvanhovell May 6, 2016
9be3ad4
Merge remote-tracking branch 'apache-github/master' into SPARK-15122
hvanhovell May 6, 2016
f146c96
Merge remote-tracking branch 'apache-github/master' into SPARK-15122
hvanhovell May 6, 2016
b487925
Move boolean simplification & remove rewrite.
hvanhovell May 6, 2016
e28bbb6
Revert: Move boolean simplification & remove rewrite.
hvanhovell May 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import org.apache.spark.sql.catalyst.catalog.{InMemoryCatalog, SessionCatalog}
import org.apache.spark.sql.catalyst.encoders.OuterScopes
import org.apache.spark.sql.catalyst.expressions._
import org.apache.spark.sql.catalyst.expressions.aggregate._
import org.apache.spark.sql.catalyst.optimizer.BooleanSimplification
Copy link
Contributor

@davies davies May 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It weird to use optimizer rule in analyzer. We could have this workaround for now, could you create a JIRA for do a proper fix later?

Copy link
Contributor Author

@hvanhovell hvanhovell May 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree on that. I could move the rule from optimizer to analysis.

Copy link
Contributor Author

@hvanhovell hvanhovell May 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the rule in the latest commit.

import org.apache.spark.sql.catalyst.planning.IntegerIndex
import org.apache.spark.sql.catalyst.plans._
import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, _}
Expand Down Expand Up @@ -958,7 +959,8 @@ class Analyzer(
localPredicateReferences -- p.outputSet
}

val transformed = sub transformUp {
// Simplify the predicates before pulling them out.
val transformed = BooleanSimplification(sub) transformUp {
case f @ Filter(cond, child) =>
// Find all predicates with an outer reference.
val (correlated, local) = splitConjunctivePredicates(cond).partition(containsOuter)
Expand Down
12 changes: 12 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,4 +281,16 @@ class SubquerySuite extends QueryTest with SharedSQLContext {
assert(msg1.getMessage.contains(
"The correlated scalar subquery can only contain equality predicates"))
}

test("disjunctive correlated scalar subquery") {
checkAnswer(
sql("""
|select a
|from l
|where (select count(*)
| from r
| where (a = c and d = 2.0) or (a = c and d = 1.0)) > 0
""".stripMargin),
Row(3) :: Nil)
}
}