Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR corrects the implementation of Row.__call__ so that let the object acts like class.

How was this patch tested?

Unittests in pyspark/sql/types.py.

Closes #10356

@HyukjinKwon
Copy link
Member Author

I submitted this PR because the author is not answering (for about four months). If the author answers or this PR is problematic, I am happy to close this.

@JoshRosen Could you please take a look?

@SparkQA
Copy link

SparkQA commented May 7, 2016

Test build #58057 has finished for PR 12973 at commit cf1fd05.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon changed the title [SPARK-12377][PySpark] Missing argments in implementation for Row.__call__ in PySpark [WIP][SPARK-12377][PySpark] Missing argments in implementation for Row.__call__ in PySpark May 7, 2016
@SparkQA
Copy link

SparkQA commented May 7, 2016

Test build #58058 has finished for PR 12973 at commit 378f195.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented May 7, 2016

Oh I see. The usage was as below and it seems correctly working

>>> row = Row("f1", "f2")
>>> row(1, 2)
Row(f1=1, f2=2)

Sorry, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants