[SPARK-15211][SQL] Select features column from LibSVMRelation causes failure #12986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #58099 has finished for PR 12986 at commit
|
Member
Author
|
ping @liancheng @yhuai Please take a look of this. Thanks. |
Contributor
|
LGTM. This bug was introduced in #12866. Thanks for fixing this! I'm merging it to master and branch-2.0. |
asfgit
pushed a commit
that referenced
this pull request
May 9, 2016
…failure ## What changes were proposed in this pull request? We need to use `requiredSchema` in `LibSVMRelation` to project the fetch required columns when loading data from this data source. Otherwise, when users try to select `features` column, it will cause failure. ## How was this patch tested? `LibSVMRelationSuite`. Author: Liang-Chi Hsieh <simonh@tw.ibm.com> Closes #12986 from viirya/fix-libsvmrelation. (cherry picked from commit 635ef40) Signed-off-by: Cheng Lian <lian@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We need to use
requiredSchemainLibSVMRelationto project the fetch required columns when loading data from this data source. Otherwise, when users try to selectfeaturescolumn, it will cause failure.How was this patch tested?
LibSVMRelationSuite.