[SPARK-15316][PySpark][ML] Add linkPredictionCol to GeneralizedLinearRegression #13106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c to generate the bullet list
|
Test build #58592 has finished for PR 13106 at commit
|
python/pyspark/ml/regression.py
Outdated
| ... (2.0, Vectors.dense(1.0, 1.0)),], ["label", "features"]) | ||
| >>> glr = GeneralizedLinearRegression(family="gaussian", link="identity") | ||
| >>> glr = GeneralizedLinearRegression(family="gaussian", link="identity", linkPredictionCol="p") | ||
| >>> print(glr.getLinkPredictionCol()) |
Contributor
There was a problem hiding this comment.
minor, but is this really necessary? By definition it would be set correctly if the test below succeeds >>> abs(transformed.head().p - 1.5) < 0.001
Contributor
Author
There was a problem hiding this comment.
Makes sense, I'll remove it.
Contributor
|
A minor comment, otherwise LGTM. |
|
Test build #58630 has finished for PR 13106 at commit
|
Contributor
|
LGTM |
Contributor
Author
|
Shall we merge then? |
Contributor
|
Yup - merged to master/branch-2.0. Thanks for the reminder. |
asfgit
pushed a commit
that referenced
this pull request
May 19, 2016
…Regression ## What changes were proposed in this pull request? Add linkPredictionCol to GeneralizedLinearRegression and fix the PyDoc to generate the bullet list ## How was this patch tested? doctests & built docs locally Author: Holden Karau <holden@us.ibm.com> Closes #13106 from holdenk/SPARK-15316-add-linkPredictionCol-toGeneralizedLinearRegression. (cherry picked from commit e71cd96) Signed-off-by: Nick Pentreath <nickp@za.ibm.com>
asfgit
pushed a commit
that referenced
this pull request
May 20, 2016
…nkPredictionCol for GeneralizedLinearRegression ## What changes were proposed in this pull request? Default value mismatch of param linkPredictionCol for GeneralizedLinearRegression between PySpark and Scala. That is because default value conflict between #13106 and #13129. This causes ml.tests failed. ## How was this patch tested? Existing tests. Author: Liang-Chi Hsieh <simonh@tw.ibm.com> Closes #13220 from viirya/hotfix-regresstion. (cherry picked from commit 4e73933) Signed-off-by: Nick Pentreath <nickp@za.ibm.com>
asfgit
pushed a commit
that referenced
this pull request
May 20, 2016
…nkPredictionCol for GeneralizedLinearRegression ## What changes were proposed in this pull request? Default value mismatch of param linkPredictionCol for GeneralizedLinearRegression between PySpark and Scala. That is because default value conflict between #13106 and #13129. This causes ml.tests failed. ## How was this patch tested? Existing tests. Author: Liang-Chi Hsieh <simonh@tw.ibm.com> Closes #13220 from viirya/hotfix-regresstion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add linkPredictionCol to GeneralizedLinearRegression and fix the PyDoc to generate the bullet list
How was this patch tested?
doctests & built docs locally