-
Notifications
You must be signed in to change notification settings - Fork 29k
[MINOR][SPARKR][DOC] Add a description for running unit tests in Windows #13217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @sun-rui |
|
Test build #58963 has finished for PR 13217 at commit
|
|
Test build #58962 has finished for PR 13217 at commit
|
R/WINDOWS.md
Outdated
| 1. Set `HADOOP_HOME`. | ||
| 2. Download `winutils.exe` and locate this in `$HADOOP_HOME/bin`. | ||
|
|
||
| It seems not requiring installing Hadoop but only this `winutils.exe`. It seems not included in Hadoop official binary releases so it should be built from source but it seems it is able to be downloaded from community (e.g. [steveloughran/winutils](https://github.com/steveloughran/winutils)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @steveloughran for comment. I think the paragraph should start with "It is not included in the Hadoop binary releases, so .... However it is downloadable from, for example [...]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I will wait for the comment and will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't recommend putting it under the root of the project, as that only complicates the source tree and path cleanup; an adjacent directory works. And I think you may find that HADOOP.DLL is needed in places, as there are some JNI calls related to local file access and permissions/ACLs
At some point we (the Hadoop team) may start releasing the Windows binaries direct. It's only avoided as it complicates the release process somewhat, though if it encourages testing it can only be encouraged.
I'd suggest the following text:
To run the SparkR unit tests on Windows, the following steps are required —assuming you are in the Spark root directory and do not have Apache Hadoop installed already:
cd ..mkdir hadoop- Download the relevant Hadoop bin package from steveloughran/winutils. While these are not official ASF artifacts, they are built from the ASF release git hashes by a Hadoop PMC member on a dedicated Windows VM.
- Install the files into
hadoop\bin; make sure thatwinutils.exeandhadoop.dllare present. - Set the environment variable
HADOOP_HOMEto the full path to the newly createdhadoopdirectory. - For further reading, consult Windows Problems on the Hadoop wiki
|
|
wait to see if someone can test the documentation. |
|
Test build #59051 has finished for PR 13217 at commit
|
|
@sun-rui @steveloughran While it seems obviously better for someone to follow and test this, I wonder who is going to test this and leave some comments here. I opened this PR during working on #13165, which I started to work on because #7025 is getting stale for several months. In this way, it seems nobody would want to try this. (In that way, #13165 will also never be merged unless someone is trying to test. I would quit and close it if I should work on something which it seems will never be merged). Maybe it would be better, at least for this one, to merge this for users/developers to follow this document to test, since it is a minor which does not affect the code base. |
|
@HyukjinKwon, maybe we can merge this first. I will probably have a try later. |
|
@HyukjinKwon - Thanks a lot for updating the documentation and for working on #13165 - I think there are a number of R users who use Windows and having SparkR work on Windows (at least for the purposes of trying it out) is useful for the Spark project. That said it has been hard to find people who have the time / resources to test SparkR on Windows machines. I wrote the initial instructions for building in Windows but a bunch of stuff has changed since then. I think this documentation change LGTM and we can come back and update it if we find a problem. Merging this to master, branch-2.0 |
|
@shivaram Thank you so much. |
## What changes were proposed in this pull request? This PR adds the description for running unit tests in Windows. ## How was this patch tested? On a bare machine (Window 7, 32bits), this was manually built and tested. Author: hyukjinkwon <gurwls223@gmail.com> Closes #13217 from HyukjinKwon/minor-r-doc. (cherry picked from commit a8e97d1) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
What changes were proposed in this pull request?
This PR adds the description for running unit tests in Windows.
How was this patch tested?
On a bare machine (Window 7, 32bits), this was manually built and tested.