[SPARK-15520] [SQL] SparkSession builder in python should also allow overriding confs of existing sessions #13289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #59247 has finished for PR 13289 at commit
|
|
Test build #59248 has finished for PR 13289 at commit
|
Contributor
|
Looks good. Merging into master 2.0. |
asfgit
pushed a commit
that referenced
this pull request
May 25, 2016
…verriding confs of existing sessions ## What changes were proposed in this pull request? This fixes the python SparkSession builder to allow setting confs correctly. This was a leftover TODO from #13200. ## How was this patch tested? Python doc tests. cc andrewor14 Author: Eric Liang <ekl@databricks.com> Closes #13289 from ericl/spark-15520. (cherry picked from commit 8239fdc) Signed-off-by: Andrew Or <andrew@databricks.com>
| for key, value in self._options.items(): | ||
| sparkConf.set(key, value) | ||
| sc = SparkContext.getOrCreate(sparkConf) | ||
| session = SparkSession(sc) |
Contributor
There was a problem hiding this comment.
actually before this line we might have to explicitly set the confs through sc.conf.set, since the SparkContext may be an existing one. There was a patch that did this for scala recently: 01e7b9c
asfgit
pushed a commit
that referenced
this pull request
May 26, 2016
…n builder in pyspark ## What changes were proposed in this pull request? Also sets confs in the underlying sc when using SparkSession.builder.getOrCreate(). This is a bug-fix from a post-merge comment in #13289 ## How was this patch tested? Python doc-tests. Author: Eric Liang <ekl@databricks.com> Closes #13309 from ericl/spark-15520-1. (cherry picked from commit 594a1bf) Signed-off-by: Andrew Or <andrew@databricks.com>
asfgit
pushed a commit
that referenced
this pull request
May 26, 2016
…n builder in pyspark ## What changes were proposed in this pull request? Also sets confs in the underlying sc when using SparkSession.builder.getOrCreate(). This is a bug-fix from a post-merge comment in #13289 ## How was this patch tested? Python doc-tests. Author: Eric Liang <ekl@databricks.com> Closes #13309 from ericl/spark-15520-1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This fixes the python SparkSession builder to allow setting confs correctly. This was a leftover TODO from #13200.
How was this patch tested?
Python doc tests.
cc @andrewor14