[SPARK-12988][SQL]Can't drop top level columns that contain dots #13306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clockfly
force-pushed
the
fix_drop_column
branch
2 times, most recently
from
f74800f to
7966bb7
Compare
clockfly
changed the title
clockfly
changed the title
|
Test build #59303 has finished for PR 13306 at commit
|
|
Test build #59304 has finished for PR 13306 at commit
|
Contributor
|
LGTM merging to master and branch 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 1, 2016
## What changes were proposed in this pull request? Fixes "Can't drop top level columns that contain dots". This work is based on dilipbiswal's #10943. This PR fixes problems like: ``` scala> Seq((1, 2)).toDF("a.b", "a.c").drop("a.b") org.apache.spark.sql.AnalysisException: cannot resolve '`a.c`' given input columns: [a.b, a.c]; ``` `drop(columnName)` can only be used to drop top level column, so, we should parse the column name literally WITHOUT interpreting dot "." We should also NOT interpret back tick "`", otherwise it is hard to understand what ``` ```aaa```bbb`` ``` actually means. ## How was this patch tested? Unit tests. Author: Sean Zhong <seanzhong@databricks.com> Closes #13306 from clockfly/fix_drop_column. (cherry picked from commit 06514d6) Signed-off-by: Yin Huai <yhuai@databricks.com>
Contributor
|
This PR makes the behavior of drop and withColumn consistent. Let's decide what we do for backticks in a separate JIRA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes "Can't drop top level columns that contain dots".
This work is based on @dilipbiswal's #10943.
This PR fixes problems like:
drop(columnName)can only be used to drop top level column, so, we should parse the column name literally WITHOUT interpreting dot "."We should also NOT interpret back tick "`", otherwise it is hard to understand what
actually means.
How was this patch tested?
Unit tests.