-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-15780][SQL] Support mapValues on KeyValueGroupedDataset #13526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
koertkuipers
wants to merge
8
commits into
apache:master
from
tresata-opensource:feat-keyvaluegroupeddataset-mapvalues
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3494ec5
add mapValues to KeyValueGroupedDataset
koertkuipers 315f8ce
fix mapValues examples in comments
koertkuipers 52b19c1
make clear example is java 8
koertkuipers 8675e94
fix some formatting and doc comments for KeyValueGroupedDataset.mapVa…
koertkuipers 846b638
Merge branch 'master' into feat-keyvaluegroupeddataset-mapvalues
koertkuipers a2bef60
update since for mapValues since the 2.0.0 ship has sailed
koertkuipers 1f4b2bd
Merge branch 'master' into feat-keyvaluegroupeddataset-mapvalues
koertkuipers 1bdc254
fix for change in AppendColumns constructor
koertkuipers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -336,6 +336,17 @@ class DatasetSuite extends QueryTest with SharedSQLContext { | |
| "a", "30", "b", "3", "c", "1") | ||
| } | ||
|
|
||
| test("groupBy function, mapValues, flatMap") { | ||
| val ds = Seq(("a", 10), ("a", 20), ("b", 1), ("b", 2), ("c", 1)).toDS() | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it seems the other tests all use |
||
| val keyValue = ds.groupByKey(_._1).mapValues(_._2) | ||
| val agged = keyValue.mapGroups { case (g, iter) => (g, iter.sum) } | ||
| checkDataset(agged, ("a", 30), ("b", 3), ("c", 1)) | ||
|
|
||
| val keyValue1 = ds.groupByKey(t => (t._1, "key")).mapValues(t => (t._2, "value")) | ||
| val agged1 = keyValue1.mapGroups { case (g, iter) => (g._1, iter.map(_._1).sum) } | ||
| checkDataset(agged, ("a", 30), ("b", 3), ("c", 1)) | ||
| } | ||
|
|
||
| test("groupBy function, reduce") { | ||
| val ds = Seq("abc", "xyz", "hello").toDS() | ||
| val agged = ds.groupByKey(_.length).reduceGroups(_ + _) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you use
T : Encoder, i.e. with spaces before and after:while...