Skip to content

Conversation

@WeichenXu123
Copy link
Contributor

What changes were proposed in this pull request?

Word2vec python add maxsentence parameter.

How was this patch tested?

Existing test.

@srowen
Copy link
Member

srowen commented Jun 9, 2016

Seems OK

@WeichenXu123
Copy link
Contributor Author

WeichenXu123 commented Jun 9, 2016

@srowen Hi srowen, I have another similar PR #13558 which pass test on my machine, but the official test fail. It seems to be the test server's problem, can you help to check it ?

@SparkQA
Copy link

SparkQA commented Jun 9, 2016

Test build #60237 has finished for PR 13578 at commit 57384a0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MLnick
Copy link
Contributor

MLnick commented Jun 9, 2016

LGTM

asfgit pushed a commit that referenced this pull request Jun 10, 2016
## What changes were proposed in this pull request?

Word2vec python add maxsentence parameter.

## How was this patch tested?

Existing test.

Author: WeichenXu <WeichenXu123@outlook.com>

Closes #13578 from WeichenXu123/word2vec_python_add_maxsentence.

(cherry picked from commit cdd7f5a)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen
Copy link
Member

srowen commented Jun 10, 2016

Merged to master/2.0

@asfgit asfgit closed this in cdd7f5a Jun 10, 2016
@WeichenXu123 WeichenXu123 deleted the word2vec_python_add_maxsentence branch June 10, 2016 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants