[SPARK-16100][SQL] fix bug when use Map as the buffer type of Aggregator #13835
+32
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Is this PR #13811 related? |
|
Test build #61003 has finished for PR 13835 at commit
|
Contributor
Author
|
retest this please |
|
Test build #61302 has finished for PR 13835 at commit
|
Contributor
|
LGTM, merging to master and branch-2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 28, 2016
## What changes were proposed in this pull request? The root cause is in `MapObjects`. Its parameter `loopVar` is not declared as child, but sometimes can be same with `lambdaFunction`(e.g. the function that takes `loopVar` and produces `lambdaFunction` may be `identity`), which is a child. This brings trouble when call `withNewChildren`, it may mistakenly treat `loopVar` as a child and cause `IndexOutOfBoundsException: 0` later. This PR fixes this bug by simply pulling out the paremters from `LambdaVariable` and pass them to `MapObjects` directly. ## How was this patch tested? new test in `DatasetAggregatorSuite` Author: Wenchen Fan <wenchen@databricks.com> Closes #13835 from cloud-fan/map-objects. (cherry picked from commit 8a977b0) Signed-off-by: Cheng Lian <lian@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The root cause is in
MapObjects. Its parameterloopVaris not declared as child, but sometimes can be same withlambdaFunction(e.g. the function that takesloopVarand produceslambdaFunctionmay beidentity), which is a child. This brings trouble when callwithNewChildren, it may mistakenly treatloopVaras a child and causeIndexOutOfBoundsException: 0later.This PR fixes this bug by simply pulling out the paremters from
LambdaVariableand pass them toMapObjectsdirectly.How was this patch tested?
new test in
DatasetAggregatorSuite