-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-16221][SQL] Redirect Parquet JUL logger via SLF4J for WRITE operations #13918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…erations Remove a legacy try-catch block and fix some typos. (Bug)
|
Test build #61287 has finished for PR 13918 at commit
|
|
Test build #61290 has finished for PR 13918 at commit
|
|
Hi, @liancheng . |
| conf.setBoolean(ParquetOutputFormat.ENABLE_JOB_SUMMARY, false) | ||
| } | ||
|
|
||
| ParquetFileFormat.redirectParquetLogs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add () since this method is defined with () and is invoked for side effect only.
|
LGTM except for one minor comment. Thanks for fixing this annoying issue! |
|
Thank you, @liancheng ! I fixed it. |
|
Test build #61306 has finished for PR 13918 at commit
|
|
Hi, @liancheng . |
|
Thanks, merged to master. @rxin Shall we have this in branch-2.0 at this stage? |
|
Thank you for merging, @liancheng ! :) |
|
Yea it's good to have this in branch-2.0. |
What changes were proposed in this pull request?
SPARK-8118 implements redirecting Parquet JUL logger via SLF4J, but it is currently applied only when READ operations occurs. If users use only WRITE operations, there occurs many Parquet logs.
This PR makes the redirection work on WRITE operations, too.
Before
After
This PR also fixes some typos.
How was this patch tested?
Manual.