Skip to content

[SPARK-16245] [ML] model loading backward compatibility for ml.feature.PCA #13937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yanboliang wants to merge 3 commits into from
Closed

[SPARK-16245] [ML] model loading backward compatibility for ml.feature.PCA #13937

yanboliang wants to merge 3 commits into from

Conversation

@yanboliang
Copy link
Contributor

@yanboliang yanboliang commented Jun 28, 2016 •
edited
Loading

What changes were proposed in this pull request?

model loading backward compatibility for ml.feature.PCA.

How was this patch tested?

existing ut and manual test for loading models saved by Spark 1.6.

@yanboliang
Copy link
Contributor Author

yanboliang commented Jun 28, 2016

cc @hhbyyh @mengxr

@hhbyyh
Copy link
Contributor

hhbyyh commented Jun 28, 2016

LGTM

@SparkQA
Copy link

SparkQA commented Jun 28, 2016

Test build #61349 has finished for PR 13937 at commit 5246bcf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 28, 2016

Test build #61351 has finished for PR 13937 at commit ce04e08.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 28, 2016

Test build #61350 has finished for PR 13937 at commit 8be63d5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Jun 29, 2016

Merged into master and branch-2.0. Thanks!

asfgit pushed a commit that referenced this pull request Jun 29, 2016
@yanboliang @mengxr
[SPARK-16245][ML] model loading backward compatibility for ml.feature…
22b4072 
….PCA

## What changes were proposed in this pull request?
model loading backward compatibility for ml.feature.PCA.

## How was this patch tested?
existing ut and manual test for loading models saved by Spark 1.6.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #13937 from yanboliang/spark-16245.

(cherry picked from commit 0df5ce1)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 0df5ce1 Jun 29, 2016
@yanboliang yanboliang deleted the spark-16245 branch June 29, 2016 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanboliang @hhbyyh @SparkQA @mengxr