[SPARK-16248][SQL] Whitelist the list of Hive fallback functions #13939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // regexp, sentences, stack, std, str_to_map, windowingtablefunction, xpath, xpath_boolean, | ||
| // xpath_double, xpath_float, xpath_int, xpath_long, xpath_number, | ||
| // xpath_short, and xpath_string. | ||
| private val hiveFunctions = Seq("percentile", "percentile_approx") |
|
Test build #61358 has finished for PR 13939 at commit
|
rxin
changed the title
|
Test build #61365 has finished for PR 13939 at commit
|
Contributor
|
test this please |
|
Test build #61386 has finished for PR 13939 at commit
|
| // built-in function. | ||
| // Hive is case insensitive. | ||
| val functionName = funcName.unquotedString.toLowerCase | ||
| if (!hiveFunctions.contains(functionName)) { |
Contributor
There was a problem hiding this comment.
Is there a TODO above that can be removed?
Contributor
|
LGTM |
|
Test build #61418 has finished for PR 13939 at commit
|
|
Test build #61426 has finished for PR 13939 at commit
|
Contributor
Author
|
Merging in master/2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 29, 2016
## What changes were proposed in this pull request? This patch removes the blind fallback into Hive for functions. Instead, it creates a whitelist and adds only a small number of functions to the whitelist, i.e. the ones we intend to support in the long run in Spark. ## How was this patch tested? Updated tests to reflect the change. Author: Reynold Xin <rxin@databricks.com> Closes #13939 from rxin/hive-whitelist. (cherry picked from commit 363bced) Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch removes the blind fallback into Hive for functions. Instead, it creates a whitelist and adds only a small number of functions to the whitelist, i.e. the ones we intend to support in the long run in Spark.
How was this patch tested?
Updated tests to reflect the change.