[SPARK-16259] [PYSPARK] cleanup options in DataFrame read/write API #13948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @rxin |
|
Test build #61392 has started for PR 13948 at commit |
|
Test build #61394 has started for PR 13948 at commit |
Contributor
|
jenkins, test this please |
Member
|
looks good! |
|
Test build #61396 has finished for PR 13948 at commit
|
Contributor
|
LGTM - merging in master. Thanks! |
Member
|
@rxin why don't we merge this one to 2.0? |
Contributor
|
Feel free to do it - but please take another careful look before you cherry pick. |
asfgit
pushed a commit
that referenced
this pull request
Jun 29, 2016
## What changes were proposed in this pull request? There are some duplicated code for options in DataFrame reader/writer API, this PR clean them up, it also fix a bug for `escapeQuotes` of csv(). ## How was this patch tested? Existing tests. Author: Davies Liu <davies@databricks.com> Closes #13948 from davies/csv_options.
Member
|
Merged to 2.0 as well. |
asfgit
pushed a commit
that referenced
this pull request
Jun 29, 2016
## What changes were proposed in this pull request? This PR corrects ORC compression option for PySpark as well. I think this was missed mistakenly in #13948. ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closes #13963 from HyukjinKwon/minor-orc-compress. (cherry picked from commit d8a87a3) Signed-off-by: Davies Liu <davies.liu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are some duplicated code for options in DataFrame reader/writer API, this PR clean them up, it also fix a bug for
escapeQuotesof csv().How was this patch tested?
Existing tests.