[SPARK-16021] Fill freed memory in test to help catch correctness bugs #13983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #61510 has finished for PR 13983 at commit
|
Member
|
LGTM |
Contributor
|
Merging in master. |
|
|
||
| @Test | ||
| public void memoryDebugFillEnabledInTest() { | ||
| Assert.assertTrue(MemoryAllocator.MEMORY_DEBUG_FILL_ENABLED); |
Contributor
There was a problem hiding this comment.
This assertion fails in Jenkins.
Did you intend to set the flag to true in a static block at the beginning of the test ?
Contributor
There was a problem hiding this comment.
Yea I think the problem is that Maven doesn't have the property set, because it is set only in SBT.
cc @ericl we need to set that in Maven too.
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Jul 7, 2016
## What changes were proposed in this pull request? Fixed the maven build for apache#13983 ## How was this patch tested? The existing tests. Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#14084 from zsxwing/fix-maven.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patches
MemoryAllocatorto fill clean and freed memory with known byte values, similar to https://github.com/jemalloc/jemalloc/wiki/Use-Case:-Find-a-memory-corruption-bug . Memory filling is flag-enabled in test only by default.How was this patch tested?
Unit test that it's on in test.
cc @sameeragarwal