-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-16399] [PYSPARK] Force PYSPARK_PYTHON to python #14016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ping @srowen @JoshRosen |
|
If I recall, the original motivation for preferring the |
|
Thanks for clarifying! It might be a good time to get rid of it.. |
bin/pyspark
Outdated
| else | ||
| DEFAULT_PYTHON="python" | ||
| fi | ||
| DEFAULT_PYTHON="python" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't even need to be a variable anymore right?
|
@srowen fixed. |
|
Test build #61623 has finished for PR 14016 at commit
|
|
Test build #61632 has finished for PR 14016 at commit
|
|
Test build #61633 has finished for PR 14016 at commit
|
|
Is this safe to merge for 2.0.0? I don't think Python 2.6 support is officially gone yet. It seems OK for If it's only for master we should not attach this to SPARK-15761 |
|
I agree with you, I created a new JIRA and renamed the title. |
|
Merged to master |
What changes were proposed in this pull request?
I would like to change
to just
DEFAULT_PYTHON="python"I'm not sure if it is a great assumption that python2.7 is used by default, when python points to something else.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)