Skip to content

Conversation

@gatorsmile
Copy link
Member

What changes were proposed in this pull request?

LogicalPlan InsertIntoHiveTable is useless. Thus, we can remove it from the code base.

How was this patch tested?

The existing test cases

@gatorsmile gatorsmile changed the title [SPARK-16358] [SQL] Remove LogicalPlan Node InsertIntoHiveTable [SPARK-16358] [SQL] Remove InsertIntoHiveTable From Logical Plan Jul 4, 2016
@SparkQA
Copy link

SparkQA commented Jul 4, 2016

Test build #61700 has finished for PR 14037 at commit 5530269.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

cc @rxin @cloud-fan @liancheng @yhuai

@cloud-fan
Copy link
Contributor

LGTM, do you know why we have this before?

@gatorsmile
Copy link
Member Author

Based on my understanding, previously, we had an Analyzer rule PreInsertionCasts, which generates InsertIntoHiveTable
https://github.com/apache/spark/pull/13754/files#diff-ee66e11b56c21364760a5ed2b783f863L483

In one of your PRs (#13754), that rule is removed. After that, InsertIntoHiveTable becomes useless.

@cloud-fan
Copy link
Contributor

merging to master, thanks!

@asfgit asfgit closed this in 2628333 Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants