-
Notifications
You must be signed in to change notification settings - Fork 29k
[MINOR][PySpark][DOC] Fix wrongly formatted examples in PySpark documentation #14063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #61804 has finished for PR 14063 at commit
|
|
Oh, I will fix them up soon. |
|
Test build #61808 has finished for PR 14063 at commit
|
|
Test build #61810 has finished for PR 14063 at commit
|
|
Can you verify the output after the all the follow-up commits? |
|
Sure, It seems the output (representation) for nested class is varied by the version of Python. First, I updated this to Expected:
<pyspark.sql.session.SparkSession.Builder object at ...>
Got:
<pyspark.sql.session.Builder object at 0x000000000163e4b8>then I updated this to Expected:
<pyspark.sql.session.Builder object at ...>
Got:
<pyspark.sql.session.SparkSession.Builder object at 0x7f8c5657d9e8>I tested this with Python 2.7 and 3.4 with this module below:
|
|
Output is fine -- I just want to make sure the doc is correct. |
|
Can you scan the Python docs and see if there are more instances? http://people.apache.org/~pwendell/spark-releases/spark-2.0.0-rc2-docs/api/python/pyspark.sql.html I found at least one ... |
|
Sure! |
|
I just double-checked the built documentation after the last commit. Do you want me to scan other modules (maybe in another PR) as well? |
|
If you can please check other modules too. Thanks! |
|
Sure! Thanks. |
|
Test build #61825 has finished for PR 14063 at commit
|
|
Test build #61826 has finished for PR 14063 at commit
|
|
@rxin It seems these are all instances related with this (I can't believe!). I just simply corrected indentation for a doc-test in |
|
Test build #61833 has finished for PR 14063 at commit
|
|
Merging in master/2.0. Thanks. |
…entation
## What changes were proposed in this pull request?
This PR fixes wrongly formatted examples in PySpark documentation as below:
- **`SparkSession`**
- **Before**

- **After**

- **`Builder`**
- **Before**

- **After**

This PR also fixes several similar instances across the documentation in `sql` PySpark module.
## How was this patch tested?
N/A
Author: hyukjinkwon <gurwls223@gmail.com>
Closes #14063 from HyukjinKwon/minor-pyspark-builder.
(cherry picked from commit 4e14199)
Signed-off-by: Reynold Xin <rxin@databricks.com>

What changes were proposed in this pull request?
This PR fixes wrongly formatted examples in PySpark documentation as below:
SparkSessionBefore
After
BuilderThis PR also fixes several similar instances across the documentation in
sqlPySpark module.How was this patch tested?
N/A