[SPARK-16212][STREAMING][KAFKA] apply test tweaks from 0-10 to 0-8 as well #14073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@srowen regarding your message on the mailing list about seeing DirectKafkaStreamSuite failures, can you see if this is more reliable for you? |
|
Test build #61861 has finished for PR 14073 at commit
|
Member
|
@koeninger yeah this patch applied to 2.0.0 RC2 makes that test pass for me. Looks good for 2.0 IMHO |
|
|
||
| // Send data to Kafka and wait for it to be received | ||
| def sendDataAndWaitForReceive(data: Seq[Int]) { | ||
| def sendData(data: Seq[Int]) { |
Contributor
There was a problem hiding this comment.
actually, can you remind me why was this test changed from testing the received data to just testing the number of records received?
Contributor
|
LGTM. Merging this to master and 2.0 |
asfgit
pushed a commit
that referenced
this pull request
Jul 6, 2016
… well ## What changes were proposed in this pull request? Bring the kafka-0-8 subproject up to date with some test modifications from development on 0-10. Main changes are - eliminating waits on concurrent queue in favor of an assert on received results, - atomics instead of volatile (although this probably doesn't matter) - increasing uniqueness of topic names ## How was this patch tested? Unit tests Author: cody koeninger <cody@koeninger.org> Closes #14073 from koeninger/kafka-0-8-test-direct-cleanup. (cherry picked from commit b8ebf63) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Bring the kafka-0-8 subproject up to date with some test modifications from development on 0-10.
Main changes are
How was this patch tested?
Unit tests