Skip to content

[SPARK-16371][SQL] Two follow-up tasks #14074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rxin wants to merge 1 commit into from
Closed

[SPARK-16371][SQL] Two follow-up tasks #14074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,10 +413,10 @@ object StructType extends AbstractDataType {
StructType(fields.asScala)
}

protected[sql] def fromAttributes(attributes: Seq[Attribute]): StructType =
private[sql] def fromAttributes(attributes: Seq[Attribute]): StructType =
StructType(attributes.map(a => StructField(a.name, a.dataType, a.nullable, a.metadata)))

def removeMetadata(key: String, dt: DataType): DataType =
private[sql] def removeMetadata(key: String, dt: DataType): DataType =
dt match {
case StructType(fields) =>
val newFields = fields.map { f =>
Expand Down
2 changes: 1 addition & 1 deletion ...rc/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ class ParquetFilterSuite extends QueryTest with ParquetTest with SharedSQLContex
}
}

test("Do not push down filters incorrectly when inner name and outer name are the same") {
test("SPARK-16371 Do not push down filters when inner name and outer name are the same") {
Copy link
Member

@HyukjinKwon HyukjinKwon Jul 7, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rxin, I am sorry for asking such a question but I couldn't find the documentation for this.

I am sometimes confused if I should add the JIRA number as prefix of a test or not. I am trying to comply this rule which I think is, writing single test requires to add the JIRA number in the test name and writing multiple tests does not (per-PR, per-JIRA).

Is this just encouraged to write this always? If so, I will try to comply this from now on and will help you leave such comments when I happened to look at some other PRs.

(I don't intend to change this across codebase but the main reason why I am asking is, that I don't want to make a such mistake in the future..)

Copy link
Contributor Author

@rxin rxin Jul 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we are creating a test case and a patch to fix specifically a problem, it'd be good to have that in the name.

Copy link
Member

@HyukjinKwon HyukjinKwon Jul 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.

withParquetDataFrame((1 to 4).map(i => Tuple1(Tuple1(i)))) { implicit df =>
// Here the schema becomes as below:
//
Expand Down