[SPARK-16403][Examples] Cleanup to remove unused imports, consistent style, minor fixes

[BryanCutler]

What changes were proposed in this pull request?

Cleanup of examples, mostly from PySpark-ML to fix minor issues: unused imports, style consistency, pipeline_example is a duplicate, use future print funciton, and a spelling error.

• The "Pipeline Example" is duplicated by "Simple Text Classification Pipeline" in Scala, Python, and Java.
• "Estimator Transformer Param Example" is duplicated by "Simple Params Example" in Scala, Python and Java
• Synced random_forest_classifier_example.py with Scala by adding IndexToString label converted
• Synced train_validation_split.py (in Scala ModelSelectionViaTrainValidationExample) by adjusting data split, adding grid for intercept.
• RegexTokenizer was doing nothing in tokenizer_example.py and JavaTokenizerExample.java, synced with Scala version

How was this patch tested?

local tests and run modified examples

[BryanCutler]

cc @MLnick @yanboliang - either of you mind taking a look? Thanks!

[SparkQA]

Test build #61880 has finished for PR 14081 at commit a034cdd.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #61883 has finished for PR 14081 at commit 24f3d39.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #61885 has finished for PR 14081 at commit 706a4ee.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Typo still here: Guassian

[SparkQA]

Test build #61918 has finished for PR 14081 at commit 264467c.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #61922 has finished for PR 14081 at commit cc9284f.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

I'm going to merge this to master only if nobody has further comments.

[BryanCutler]

Thanks for the review Sean!
On Jul 10, 2016 4:29 AM, "Sean Owen" notifications@github.com wrote:

I'm going to merge this to master only if nobody has further comments.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#14081 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AEUwdVUFLdKDcpw7Q9lD1M2WDraafwVoks5qUNeAgaJpZM4JGm-5
.

[BryanCutler]

I realized that the "PipelineExample"s are included in the docs, while the "SimpleTextClassificationExample"s are not, so it might be better to keep those instead. I just changed the data and regularization value to that of "SimpleTextClassificationExample" which gives correct predictions (it looks like these examples were updated at one time by DB to fix this, but the change was not put into the doc example).

[SparkQA]

Test build #62072 has finished for PR 14081 at commit 81611a8.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[BryanCutler]

I noticed that in a similar vein, SimpleParamsExample was a duplicate of EstimatorTransformerParamExample in Scala, Java, and Python, and removed those.

[SparkQA]

Test build #62118 has finished for PR 14081 at commit eb13049.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Double checking with @jkbradley that the example removals look OK?

[srowen]

Merged to master

[BryanCutler]

Thanks @srowen!
On Jul 14, 2016 1:16 AM, "asfgit" notifications@github.com wrote:

Closed #14081 #14081 via e3f8a03
e3f8a03
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#14081 (comment), or mute the
thread
https://github.com/notifications/unsubscribe/AEUwdbr0gqVch0h6hBIJJ49Y89hXavKeks5qVfA9gaJpZM4JGm-5
.