[SPARK-16470][ML][Optimizer] Check linear regression training whether actually reach convergence and add warning if not #14122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #62044 has finished for PR 14122 at commit
|
| } | ||
|
|
||
| if (!state.actuallyConverged) { | ||
| logWarning("LinearRegression training fininshed but the result is not converged, " + |
Member
There was a problem hiding this comment.
LGTM though you could use string interpolation here. Maybe slightly better as "Linear regression training fininshed but the result is not converged because: ..."
|
Test build #62055 has finished for PR 14122 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jul 12, 2016
… actually reach convergence and add warning if not ## What changes were proposed in this pull request? In `ml.regression.LinearRegression`, it use breeze `LBFGS` and `OWLQN` optimizer to do data training, but do not check whether breeze's optimizer returned result actually reached convergence. The `LBFGS` and `OWLQN` optimizer in breeze finish iteration may result the following situations: 1) reach max iteration number 2) function reach value convergence 3) objective function stop improving 4) gradient reach convergence 5) search failed(due to some internal numerical error) I add warning printing code so that if the iteration result is (1) or (3) or (5) in above, it will print a warning with respective reason string. ## How was this patch tested? Manual. Author: WeichenXu <WeichenXu123@outlook.com> Closes #14122 from WeichenXu123/add_lr_not_convergence_warn. (cherry picked from commit 6cb75db) Signed-off-by: Sean Owen <sowen@cloudera.com>
Member
|
Merged to master, and 2.0 on the grounds that it's just an added informative warning |
| } | ||
|
|
||
| if (!state.actuallyConverged) { | ||
| logWarning("LinearRegression training fininshed but the result " + |
Contributor
Author
There was a problem hiding this comment.
Oh, I'm sorry, I fixed that in #14238 , thanks! @jaceklaskowski @srowen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
ml.regression.LinearRegression, it use breezeLBFGSandOWLQNoptimizer to do data training, but do not check whether breeze's optimizer returned result actually reached convergence.The
LBFGSandOWLQNoptimizer in breeze finish iteration may result the following situations:I add warning printing code so that
if the iteration result is (1) or (3) or (5) in above, it will print a warning with respective reason string.
How was this patch tested?
Manual.