Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Jul 11, 2016

What changes were proposed in this pull request?

After SPARK-16476 (committed earlier today as #14128), we can finally bump the version number.

How was this patch tested?

N/A

@rxin
Copy link
Contributor Author

rxin commented Jul 11, 2016

cc @srowen

@SparkQA
Copy link

SparkQA commented Jul 11, 2016

Test build #62075 has finished for PR 14130 at commit 2915bf1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 11, 2016

Hm I tried this recently and it failed mima. I think this has to bump the base mima version too but then it will fail because 2.0.0 isn't released. I thought we'd have to wait.

@rxin
Copy link
Contributor Author

rxin commented Jul 11, 2016

That's why I did #14128

Base mima version is still 1.6, and 2.0 and 2.1 currently has the same set of excludes.

@srowen
Copy link
Member

srowen commented Jul 11, 2016

OK, later we'd have to make the base version 2.0.0 right? that's fine though either way we have to bump something later, so was going to wait, but, no big deal either way, especially if it reduces confusion about the snapshot number

@rxin
Copy link
Contributor Author

rxin commented Jul 11, 2016

Yup once we actually release we can bump the base version. The good thing with the new approach is that we can now define mima excludes based on 2.0 or 2.1 versions already.

@rxin
Copy link
Contributor Author

rxin commented Jul 11, 2016

I'm going to merge this in master.

@asfgit asfgit closed this in ffcb6e0 Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants