[SPARK-16318][SQL] Implement all remaining xpath functions (branch-2.0) #14131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements all remaining xpath functions that Hive supports and not natively supported in Spark: xpath_int, xpath_short, xpath_long, xpath_float, xpath_double, xpath_string, and xpath. Added unit tests and end-to-end tests. Author: petermaxlee <petermaxlee@gmail.com> Closes apache#13991 from petermaxlee/SPARK-16318.
Contributor
Author
|
cc @cloud-fan |
Contributor
|
LGTM, pending jenkins |
|
Test build #62076 has finished for PR 14131 at commit
|
Contributor
|
retest this please |
Contributor
|
looks like we also need to backport the improvement to |
|
Test build #62085 has finished for PR 14131 at commit
|
## What changes were proposed in this pull request? This small patch modifies ExpressionEvalHelper. checkEvaluation to support comparing NaN values for floating point comparisons. ## How was this patch tested? This is a test harness change. Author: petermaxlee <petermaxlee@gmail.com> Closes apache#14103 from petermaxlee/SPARK-16436.
Contributor
Author
|
I've added the checkEvaluation fix here too. |
|
Test build #62096 has finished for PR 14131 at commit
|
|
Test build #3179 has finished for PR 14131 at commit
|
Contributor
|
Merging in branch-2.0. |
Contributor
|
@petermaxlee can you close this? |
asfgit
pushed a commit
that referenced
this pull request
Jul 11, 2016
## What changes were proposed in this pull request? This patch implements all remaining xpath functions that Hive supports and not natively supported in Spark: xpath_int, xpath_short, xpath_long, xpath_float, xpath_double, xpath_string, and xpath. This is based on #13991 but for branch-2.0. ## How was this patch tested? Added unit tests and end-to-end tests. Author: petermaxlee <petermaxlee@gmail.com> Closes #14131 from petermaxlee/xpath-branch-2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch implements all remaining xpath functions that Hive supports and not natively supported in Spark: xpath_int, xpath_short, xpath_long, xpath_float, xpath_double, xpath_string, and xpath.
This is based on #13991 but for branch-2.0.
How was this patch tested?
Added unit tests and end-to-end tests.