[SPARK-16563][SQL] fix spark sql thrift server FetchResults bug #14218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion FetchResults bug
Author
|
@liancheng hey, please help review (BTW are you the lian cheng from MSTC zju?) |
Contributor
|
@alicegugu could you add a unit test for this? I think there are some for the thrift server already in |
Author
|
@ericl Hi Eric, two test cases are added for the code change. Please review. Thanks! |
| assertResult(0, "Repeat fetching result from next row") { | ||
|
|
||
| // Fetch first time | ||
| val rows = client.fetchResults(operationHandle) |
Contributor
There was a problem hiding this comment.
Can you assert this also returns 5?
Contributor
|
Lgtm, just some comments on the tests |
Author
|
@ericl thanks for the comments, comments incorporated in new commit |
Contributor
|
Lgtm |
Contributor
|
Jenkins, test this please. |
|
Test build #3209 has finished for PR 14218 at commit
|
Contributor
|
Merging in master/branch-2.0. |
asfgit
pushed a commit
that referenced
this pull request
Aug 9, 2016
## What changes were proposed in this pull request? Add a constant iterator which point to head of result. The header will be used to reset iterator when fetch result from first row repeatedly. JIRA ticket https://issues.apache.org/jira/browse/SPARK-16563 ## How was this patch tested? This bug was found when using Cloudera HUE connecting to spark sql thrift server, currently SQL statement result can be only fetched for once. The fix was tested manually with Cloudera HUE, With this fix, HUE can fetch spark SQL results repeatedly through thrift server. Author: Alice <alice.gugu@gmail.com> Author: Alice <guhq@garena.com> Closes #14218 from alicegugu/SparkSQLFetchResultsBug. (cherry picked from commit e17a76e) Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a constant iterator which point to head of result. The header will be used to reset iterator when fetch result from first row repeatedly.
JIRA ticket https://issues.apache.org/jira/browse/SPARK-16563
How was this patch tested?
This bug was found when using Cloudera HUE connecting to spark sql thrift server, currently SQL statement result can be only fetched for once. The fix was tested manually with Cloudera HUE, With this fix, HUE can fetch spark SQL results repeatedly through thrift server.