Skip to content

Conversation

@keypointt
Copy link
Contributor

https://issues.apache.org/jira/browse/SPARK-16580#

What changes were proposed in this pull request?

When I was working on the R wrapper, I found the compile warn.

> project mllib
> console
[warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala:78: class Accumulator in package spark is deprecated: use AccumulatorV2
[warn]     accumulator: Accumulator[JList[Array[Byte]]])
[warn]
[warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala:78: class Accumulator in package spark is deprecated: use AccumulatorV2
[warn]     accumulator: Accumulator[JList[Array[Byte]]])
[warn]
[warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala:78: class Accumulator in package spark is deprecated: use AccumulatorV2
[warn]     accumulator: Accumulator[JList[Array[Byte]]])
[warn]
[warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala:71: class Accumulator in package spark is deprecated: use AccumulatorV2
[warn] private[spark] case class PythonFunction(
[warn]
[warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala:78: class Accumulator in package spark is deprecated: use AccumulatorV2
[warn]     accumulator: Accumulator[JList[Array[Byte]]])
[warn]
[warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala:873: trait AccumulatorParam in package spark is deprecated: use AccumulatorV2
[warn]   extends AccumulatorParam[JList[Array[Byte]]] {
[warn]
[warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala:459: trait AccumulableParam in package spark is deprecated: use AccumulatorV2
[warn]     param: org.apache.spark.AccumulableParam[R, T]) extends AccumulatorV2[T, R] {
[warn]
[warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala:459: trait AccumulableParam in package spark is deprecated: use AccumulatorV2
[warn]     param: org.apache.spark.AccumulableParam[R, T]) extends AccumulatorV2[T, R] {
[warn]

Using AccumulatorV2 and warnings on "PythonRDD.scala:78" and "PythonRDD.scala:71" disappeared.

I didn't change AccumulableParam or AccumulatorParam, since they are being used in class LegacyAccumulatorWrapper of AccumulatorV2.

How was this patch tested?

Tested manually on my laptop.

@SparkQA
Copy link

SparkQA commented Jul 15, 2016

Test build #62389 has finished for PR 14226 at commit 84db726.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 24, 2016

@keypointt what do you think about following up on this?

@keypointt
Copy link
Contributor Author

@srowen sorry, I had a very busy week passed, now I have time to look into it. Will keep you posted :)

@SparkQA
Copy link

SparkQA commented Aug 3, 2016

Test build #63192 has finished for PR 14226 at commit fe83dd9.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MLnick
Copy link
Contributor

MLnick commented Aug 5, 2016

I think #14467 is addressing this, and seems to be further along (it is a little more involved to make it work than what you have here)

@srowen
Copy link
Member

srowen commented Aug 5, 2016

Yeah let's close this one as a duplicate

@keypointt
Copy link
Contributor Author

sure, closing it

@keypointt keypointt closed this Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants